Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionSheet does not close smoothly by swipe down action #5068

Closed
2 of 5 tasks
Great-hijack opened this issue Jun 8, 2022 · 5 comments · Fixed by #5079
Closed
2 of 5 tasks

ActionSheet does not close smoothly by swipe down action #5068

Great-hijack opened this issue Jun 8, 2022 · 5 comments · Fixed by #5079
Assignees
@Viraj-10
Labels
bug triage v3 V3
Milestone
v3.4.7

Comments

@Great-hijack
Copy link

Great-hijack commented Jun 8, 2022 •
edited
Loading

Description

ActionSheet does not close smoothly by swipe down action

CodeSandbox/Snack link

https://snack.expo.dev/@zhen-zhu/actionsheet-issue-reporo

Steps to reproduce

  1. Tap 'ActionSheet' button
  2. Press the drag indicator and swipe down
  3. ActionSheet will slide down and up and down.

this is so quick action, though can detectable by naked eyes.

NativeBase Version

3.4.6

Platform

  • Android
  • CRA
  • Expo
  • iOS
  • Next

Other Platform

No response

Additional Information

Here is the video.

RPReplay_Final1655135423.MP4
@Krithikj20
Copy link
Collaborator

Hi @Great-hijack, Thank you for reporting this issue. We will look into it.

@Viraj-10
Copy link
Collaborator

Hi @Great-hijack, I am unable to reproduce it. Can record your screen and upload a video?

@Viraj-10 Viraj-10 added this to the v3.4.7 milestone Jun 13, 2022
@Great-hijack
Copy link
Author

Hi @Great-hijack, I am unable to reproduce it. Can record your screen and upload a video?

@Viraj-10 edited the issue for the video.

@Viraj-10 Viraj-10 linked a pull request Jun 20, 2022 that will close this issue
fix: actionsheet animation #5079
Merged
@Viraj-10
Copy link
Collaborator

This issue has been fixed in NativeBase v3.4.7

@Great-hijack
Copy link
Author

@Viraj-10 It works like a charm. Thanks thousand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Viraj-10 Viraj-10

Labels
bug triage v3 V3
Projects
None yet
Milestone
v3.4.7
Development

Successfully merging a pull request may close this issue.

fix: actionsheet animation GeekyAnts/NativeBase
3 participants
@Great-hijack @Viraj-10 @Krithikj20