Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitpod support #11

Closed
akosyakov opened this issue Apr 14, 2020 · 8 comments
Closed

gitpod support #11

akosyakov opened this issue Apr 14, 2020 · 8 comments

Comments

@akosyakov
Copy link

I am trying to install VS Code extension in Gitpod: https://www.gitpod.io/docs/vscode-extensions/#installing-an-extension

But running Start Session does nothing. Have you tried to run VS Code extension in Theia: https://github.com/eclipse-theia/theia/wiki/Testing-VS-Code-Extensions?

@akosyakov
Copy link
Author

From server logs:

root ERROR [hosted-plugin: 8693] Promise rejection not handled in one second: Error: System keychain unavailable , reason: Error: System keychain unavailable
root ERROR [hosted-plugin: 8693] With stack trace: Error: System keychain unavailable
    at Object.<anonymous> (/tmp/vscode-unpacked/genuitecllc.codetogether-1.0.5.vsix/extension/out/extension.js:31:30994)
    at /tmp/vscode-unpacked/genuitecllc.codetogether-1.0.5.vsix/extension/out/extension.js:31:30568
    at Object.next (/tmp/vscode-unpacked/genuitecllc.codetogether-1.0.5.vsix/extension/out/extension.js:31:30673)
    at /tmp/vscode-unpacked/genuitecllc.codetogether-1.0.5.vsix/extension/out/extension.js:31:29575
    at new Promise (<anonymous>)
    at __awaiter (/tmp/vscode-unpacked/genuitecllc.codetogether-1.0.5.vsix/extension/out/extension.js:31:29320)
    at Object.getPassword (/tmp/vscode-unpacked/genuitecllc.codetogether-1.0.5.vsix/extension/out/extension.js:31:30910)
    at Object.<anonymous> (/tmp/vscode-unpacked/genuitecllc.codetogether-1.0.5.vsix/extension/out/extension.js:31:31839)
    at /tmp/vscode-unpacked/genuitecllc.codetogether-1.0.5.vsix/extension/out/extension.js:31:30568
    at Object.next (/tmp/vscode-unpacked/genuitecllc.codetogether-1.0.5.vsix/extension/out/extension.js:31:30673)

@akosyakov
Copy link
Author

Is it about keytar? i.e. eclipse-theia/theia#6407?

@TimWebb
Copy link
Contributor

TimWebb commented Apr 14, 2020

Yes, that is indeed the case. Have you stumbled into a workaround we could apply?

@akosyakov
Copy link
Author

Adding it as a dependency? 😬

I know how to fix in Theia but there are consequences for different adopters since it requires additional system libraries to be installed. I hope we can clarify it on the dev meeting next Tuesday and then someone can send a PR.

@akosyakov
Copy link
Author

akosyakov commented Apr 21, 2020

@TimWebb Could you share how you look up keytar? Do you have code like:

return r(`${env.appRoot}/node_modules/keytar`);

@nmorenor
Copy link
Member

Hey, on CodeTogether we don't explicitly have the dependency to keytar. And to get it we do something like:

function getKeytarModule<T>(): T | undefined {
    const vscodeRequire = eval('require');
    try {
        return vscodeRequire('keytar');
    } catch (err) {
    }
    return undefined;
}

For the next release of CodeTogether we have made a change to ignore the error if we can't load keytar. The only side effect will be that at some point you'll need to re-login to be able to start a session.

@TimWebb
Copy link
Contributor

TimWebb commented Apr 29, 2020

We're testing now but basic support has been released as part of 1.1.0. Things like saving credentials will be coming later. Also, the Presence view doesn't show right as it is missing the Welcome view.

@TimWebb TimWebb closed this as completed Apr 29, 2020
@akosyakov
Copy link
Author

@TimWebb Thanks, we will have look at supporting welcomes view too.

Is there a way to join the session from user IDE or one should always use codetogether IDE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants