Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divider settings are not applied when returning from backstack #34

Closed
acleu opened this issue Jul 28, 2016 · 3 comments
Closed

Divider settings are not applied when returning from backstack #34

acleu opened this issue Jul 28, 2016 · 3 comments
Assignees
Labels

Comments

@acleu
Copy link

acleu commented Jul 28, 2016

The problem can be demonstrated using the sample app. Just uncomment the setDividerPreferences() call in MyPreferenceFragment.onCreateView() and set the dividers to DIVIDER_NONE.

When the app is started, dividers are correctly hidden. Then press "PreferenceSrceen test" and return from the subscreen. The dividers are not hidden anymore.

I test this on a Nexus 7/2013, Android 6.0.1

Apparently, when the fragment is restored, the check "divPrefFlags == flags && !divPrefInvalid" in setDividerPreferences() is true and thus, the divider preferences are not applied.

@gregkorossy gregkorossy self-assigned this Jul 28, 2016
@gregkorossy
Copy link
Owner

gregkorossy commented Jul 28, 2016

Thanks for the report. It's fixed now, though haven't been committed yet. Stay tuned.

gregkorossy added a commit that referenced this issue Jul 29, 2016
@gregkorossy
Copy link
Owner

Published v24.1.1.1 of the lib which contains the bugfix.

@acleu
Copy link
Author

acleu commented Jul 29, 2016

Wow. Great support. Incredibly fast. Thanks.

I can confirm that it works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants