Fix hidden dialog when called from Bootstrap modal. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,7 @@ window.RecurringSelectDialog = | |||
|
|
|||
| open_in = $("body") | |||
| open_in = $(".ui-page-active") if $(".ui-page-active").length | |||
| open_in = $(".modal") if $(".modal:visible").length | |||
There was a problem hiding this comment.
@rgrwatson85 Is there a better way to determine if this .modal is coming from Bootstrap? This has the potential to conflict with other peoples code if .modal means something else to them (and indeed it does in our app).
|
@rgrwatson85 I'm reverting this in 1.2.3. Please open a new pull request with a better solution. |
|
Modifying the z-index seems to work. See 7cc9dd6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialog would appear underneath Bootstrap modals if they were being used as a form.
