Changing static user feed to dynamic #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing code to from using a static (hard coded) value of `user_feed` which essentially uses the `user` actor to allow the model binding to use whatever is set in the model under `activityActorMethodName()`. This will allow anyone using a feed other than `user` to have automatic activities created/deleted with those actions.
Changing static user feed to dynamic
|
Thank you for the PR! I see your point but this approach will break the library (the user feed group is a configuration parameter, with the new code this will change the feed group used and break most apps). My recommendation is to write a custom manager and change this logic there (see feed_manager_class config entry) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing code to from using a static (hard coded) value of user_feed which essentially uses the user actor to allow the model binding to use whatever is set in the model under activityActorMethodName(). This will allow anyone using a feed other than user to have automatic activities created/deleted with those actions.
I tested this locally and it works as intended. Both regular user feeds and any added feeds will now auto create and delete activities.
Fixes #84