Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release with inclusion of builtin addr_of! macro use #51

Closed
est31 opened this issue Mar 25, 2021 · 6 comments
Closed

Release with inclusion of builtin addr_of! macro use #51

est31 opened this issue Mar 25, 2021 · 6 comments

Comments

@est31
Copy link
Contributor

est31 commented Mar 25, 2021

It would be cool to get a release out which includes #50 , now that 1.51 is released.

@RalfJung
Copy link
Collaborator

FWIW, I also have the permissions to do a release, but @Gilnaa usually does it so I'd be more likely to make a mistake in the process. ;)

@Gilnaa
Copy link
Owner

Gilnaa commented Mar 25, 2021

I have a reminder to do it later today :)

@RalfJung do you think we should release 1.0.0 now that UB is abolished?

@RalfJung
Copy link
Collaborator

RalfJung commented Mar 25, 2021

I'd say for now just make a patch release as usual. That also ensures that everyone gets the update, since it is semver-compatible.

If no problem comes up for a while, we can do another thorough review and then call it 1.0.

@est31
Copy link
Contributor Author

est31 commented Mar 25, 2021

A patch release would have the advantage of getting faster to users. They just have to cargo update, instead of people having to update it manually, sometimes deep in the dependency hierarchy.

@Gilnaa
Copy link
Owner

Gilnaa commented Mar 25, 2021

Okie dokie, all done, version v0.6.2 published to crates.io :)

@Gilnaa Gilnaa closed this as completed Mar 25, 2021
@RalfJung
Copy link
Collaborator

Thanks a lot. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants