Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove button not visible #96

Closed
sathishmscict opened this issue Nov 5, 2020 · 6 comments
Closed

Remove button not visible #96

sathishmscict opened this issue Nov 5, 2020 · 6 comments

Comments

@sathishmscict
Copy link

sathishmscict commented Nov 5, 2020

"Remove" button not visible for some of gif images from "Recent" tab. Please review below images for more information :

image

image

image

Here ,

  1. First image have only 2 options in context menu , so it could be easily clickable and remove option working fine.
  2. Second image have 3 options , so difficult to click on "Remove" option. But anyway it is clickable and remove option working fine.
  3. Coming to third image "Remove" option not visible. So, unable to perform "Remove" option in this case.
@ALexanderLonsky
Copy link
Collaborator

@sathishmscict thank you for flagging this, I'll take a look.

@ALexanderLonsky
Copy link
Collaborator

@sathishmscict please try v2.0.5.

@sathishmscict
Copy link
Author

Thank you @ALexanderLonsky . Its working as expected.
RemoveButton

@sathishmscict
Copy link
Author

sathishmscict commented Nov 16, 2020

Hi @ALexanderLonsky ,one more change we required to close this issue. After removing the all gif images is showing "Retry" button on center of the screen.

image

@ALexanderLonsky
Copy link
Collaborator

@sathishmscict hi, try please this version:
com.giphy.sdk:ui:2.0.5-recents-fix

@sathishmscict
Copy link
Author

Hi @ALexanderLonsky , now its working fine. We are closed this issue. Thank you for quick response, appreciated.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants