Improve accessibility labelling

[oherst]

Duplicates

• I have searched the existing issues

Latest version

• I have tested the latest version

Summary 💡

All buttons and images (or gifs) should have appropriate accessibility labelling.

Motivation 🔦

Hello! I believe this to be an enhancement rather than a bug so I figured a feature request would be more appropriate but I can make this request somewhere else if this is not the right place.

We are using the Giphy RN sdk in our app and have recently been audited by a third party for accessibility. They picked up some issues with our Giphy implementation and I wondered if you might be able to give your thoughts on them?

• Trending buttons don't have a name (they just announce "button").
• When previewing a gif the back button and "view on giphy button" don't have names.
• When previewing a gif the gif cannot be focused.

Additionally I note that the buttons at the bottom of the giphy main window are read as "sticker underscore type underscore button, button" which could be better (eg, sticker button). To be clear, this was not picked up by the auditors it is just something I noticed whilst testing.

Would this be something you would consider for a future enhancement?

Thanks very much.

[pshoniuk]

Hi @oherst
Thanks for the detailed report. I’ll pass this feedback on to my team & keep you in the loop.

[pshoniuk]

@oherst We released v2.4.1 with improved accessibility labels. If some of the accessibility issues mentioned here aren't resolved in v2.4.1, please reopen this issue or create a new one.

[efstathiosntonas]

thank you for this guys

[oherst]

thanks so much, can't wait to try it out!