Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Pagination #235

Open
2 tasks done
Manvityagi opened this issue May 2, 2021 · 11 comments
Open
2 tasks done

Implement Pagination #235

Manvityagi opened this issue May 2, 2021 · 11 comments
Assignees
Labels
GSSOC21 GSSOC participants LEVEL3 This issue is little harder

Comments

@Manvityagi
Copy link
Member

  • I checked to make sure that this issue has not already been filed.

  • I'm reporting the issue to the correct repository (for multi-repository projects) (optional)

Expected Behavior:

Users should be able to move from one page to another
image

Current Behavior:

All the results are shown. There is no pagination.

Solution:

The GET API can take 2 query params - page and limit. Make use of them while calling APIs and retrieving results. Default value is page=1 and limit = 10.

API Documentation

@Manvityagi Manvityagi added GSSOC21 GSSOC participants LEVEL3 This issue is little harder up-for-grabs labels May 2, 2021
@ritik307
Copy link
Contributor

ritik307 commented May 2, 2021

@Manvityagi I would like to work on this Plz assign

@Vishal1003
Copy link

@Manvityagi Is this issue still open? If yes then I would like to work on this!

@vaishali614
Copy link
Member

Issues are assigned on FCFS basis, so I'm assigning this issue to @ritik307
@Vishal1003 please find some other issue to work upon.

@ritik307 ritik307 removed their assignment May 9, 2021
@Manvityagi Manvityagi assigned ritik307 and Vishal1003 and unassigned ritik307 May 9, 2021
@Manvityagi
Copy link
Member Author

@Vishal1003 It has been assigned to you.
I think @ritik307 is not available as of now.

@akshitakanojia
Copy link
Contributor

@Manvityagi if this issue becomes available in future, I would like to work on it.

@vaishali614
Copy link
Member

@Vishal1003 Please respond if you're working on this issue, otherwise I'll have to unassign you from this issue.

@Vishal1003 Vishal1003 removed their assignment May 12, 2021
@Vishal1003
Copy link

@vaishali614 I'm really sorry. I won't be able to work on this issue as of now.

@Manvityagi
Copy link
Member Author

@Manvityagi if this issue becomes available in future, I would like to work on it.

Awesome @akshitakanojia. I have assigned to you, Feel free to comment here if you face any difficulties in implementation.

@akshitakanojia
Copy link
Contributor

@Manvityagi is it possible to get total number of pages as well in the api response, as it will be required to show the page numbers. Otherwise I can show only prev current next.

@Manvityagi
Copy link
Member Author

@Manvityagi is it possible to get total number of pages as well in the api response, as it will be required to show the page numbers. Otherwise I can show only prev current next.

Hey, yeah. We can do that.
Would you mind creating that issue in backend?

@akshitakanojia
Copy link
Contributor

okay I'll create.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSSOC21 GSSOC participants LEVEL3 This issue is little harder
Projects
None yet
Development

No branches or pull requests

5 participants