[Bug] Minor version increased instead of the prerelease tag #3137
Comments
|
Are you able to reproduce this in a |
|
I tried to reproduce this issue without any success. Thus I'm going to close it. Please reopen this bug or create a new one if you think this bug still persists. Cheers! [Test]
public void __Just_A_Test__()
{
var configuration = GitHubFlowConfigurationBuilder.New.WithSemanticVersionFormat(SemanticVersionFormat.Loose).Build();
using var fixture = new EmptyRepositoryFixture("release/0.28");
fixture.MakeACommit("+semver: patch");
// ✅ succeeds as expected
fixture.AssertFullSemver("0.28.0-beta.1+1", configuration);
} |
|
Okay I can confirm that this behavior is because of the [Test]
public void __Just_A_Test__()
{
var configuration = GitHubFlowConfigurationBuilder.New
.WithCommitMessageIncrementing(CommitMessageIncrementMode.Enabled)
.WithSemanticVersionFormat(SemanticVersionFormat.Loose).Build();
using var fixture = new EmptyRepositoryFixture("main");
fixture.MakeACommit();
fixture.BranchTo("release/0.28");
fixture.MakeACommit("+semver: patch"); // <<---
// ✅ expected: 0.28.0-beta.1+1 or 0.28.1-beta.1+1 ❔
fixture.AssertFullSemver("0.28.1-beta.1+1", configuration);
} |
|
Thanks for providing a reproduction, @HHobeck! It would be interesting to hear what @mmisztal1980 expects the version to be in that scenario. |
|
as per my original post, I was expecting the |
|
The head line was saying something different. That's why I have asked: Minor version increased instead of the prerelease tag ;)
Maybe we need to agree on the naming convention first: If we have a version like
May I ask you again what would be your expecation in the scenario with commit message [Test]
public void __Just_A_Test__()
{
var configuration = GitHubFlowConfigurationBuilder.New
.WithCommitMessageIncrementing(CommitMessageIncrementMode.Enabled)
.WithSemanticVersionFormat(SemanticVersionFormat.Loose).Build();
using var fixture = new EmptyRepositoryFixture("main");
fixture.MakeACommit();
fixture.BranchTo("release/0.28");
fixture.MakeACommit("+semver: patch"); // <<---
// ✅ expected: 0.28.0-beta.1+1 or 0.28.1-beta.1+1 or 0.28.0-beta.2+1 ❔
fixture.AssertFullSemver("0.28.1-beta.1+1", configuration);
} |
|
The patch nuber increases like the author expecting it. I'm going to close this issue because it has beend solved already in version 6.x. Thank for reporting this issue. |
|
🎉 This issue has been resolved in version 6.0.0-beta.2 🎉 Your GitReleaseManager bot 📦🚀 |
Describe the bug
A clear and concise description of what the bug is.
Expected Behavior
I'm expecting the minor version to stay the same as the one dictated by the parent
release/*branch. I'm not sure if this is due to using theminor-version-bump-message, however I was under the impression that therelease/*branch behavior should override that?Actual Behavior
dotnet giversion /diagyields:Possible Fix
Steps to Reproduce
GitVersion.yml
release/*branchgit checkout -B release/0.28feat: somethingfeaturedotnet gitversionContext
It has incremented the minor version on the release branch, ahead of the release branch's minor version
Your Environment
The text was updated successfully, but these errors were encountered: