Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Don't consider tag-prefix as optional #3216

Closed
AlexPykavy opened this issue Oct 1, 2022 · 5 comments · Fixed by #3208
Closed

[Improvement] Don't consider tag-prefix as optional #3216

AlexPykavy opened this issue Oct 1, 2022 · 5 comments · Fixed by #3208
Milestone

Comments

@AlexPykavy
Copy link
Contributor

Detailed Description

Currently tag-prefix is always considered as optional which makes calculation of the next version incorrect. It mixes prefixed and unprefixed versions and takes the largest of both.

Context

To correctly calculate the next version with the prefix. For example, we develop the main product and some its plugin in the same repository and have the following git tags list:

  • 0.1.0
  • 0.1.1
  • 0.2.0
  • 0.2.1
  • plugin_0.1.0
  • plugin_0.1.1
    The expected next plugin version is 0.1.2 not 0.2.2 (plugin_ prefix will be prepended before setting the tag).

Possible Implementation

@arturcic
Copy link
Member

Fixed by #3208

@andyfurniss4
Copy link

Is this available for use yet? If not, do you know when the next release is planned for?

I've also encountered this issue where I am trying to use GitVersion in a repo that already has a bunch of non-prefixed tags used for other things. I want my GitVersion-ing to be independent of these other tags. I need the tag-prefix to be enforced rather than optional so I can ignore all the older tags and only focus on new tags prefixed with whatever I want to prefix with.

@asbjornu
Copy link
Member

asbjornu commented Nov 1, 2022

This will be a part of our next release of v5, @andyfurniss4. We haven't planned one yet, but we do them fairly regularly.

@andyfurniss4
Copy link

Thanks @asbjornu

@arturcic arturcic modified the milestones: 5.x, 5.11.0 Nov 7, 2022
@arturcic
Copy link
Member

arturcic commented Nov 7, 2022

🎉 This issue has been resolved in version 5.11.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants