Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE]: dotnet publish: '0.0.1-abc_def.1+1' is not a valid version string #4136

Closed
2 tasks done
HenrikRoosKpa opened this issue Aug 5, 2024 · 4 comments · Fixed by #4135
Closed
2 tasks done

[ISSUE]: dotnet publish: '0.0.1-abc_def.1+1' is not a valid version string #4136

HenrikRoosKpa opened this issue Aug 5, 2024 · 4 comments · Fixed by #4135

Comments

@HenrikRoosKpa
Copy link

Prerequisites

  • I have written a descriptive issue title
  • I have searched issues to ensure it has not already been reported

GitVersion package

GitVersion.Tool

GitVersion version

6

Operating system

Windows

What are you seeing?

dotnet publish show an error: '0.0.1-abc_def.1+1' is not a valid version string, when branch name contains _.

What is expected?

FullSemVer generate an SemVer 2.0 string.

Steps to Reproduce

New-Item -Path test -Type Directory
cd test
git init
dotnet new web -o src/my-app
git add .
git commit -m "add my-app"
git checkout -b features/abc_def
dotnet-gitversion /showvariable FullSemVer
dotnet publish src/my-app -p:Version=0.0.1-abc_def.1+1 -o out

RepositoryFixture Test

No response

Output log or link to your CI build (if appropriate).

dotnet publish src/my-app -p:Version=0.0.1-abc_def.1+1 -o out
  Determining projects to restore...
C:\Program Files\dotnet\sdk\8.0.303\NuGet.targets(169,5): error : '0.0.1-abc_def.1+1' is not a valid version string. (Parameter 'value') [C:\git\test\src\my-app\my-app.csproj]
@arturcic
Copy link
Member

arturcic commented Aug 5, 2024

I think it's related to #4135

@arturcic
Copy link
Member

arturcic commented Aug 5, 2024

I will close this issue as duplicate of #4110

@arturcic arturcic closed this as completed Aug 5, 2024
@HenrikRoosKpa
Copy link
Author

Thanx @arturcic

@arturcic arturcic linked a pull request Aug 5, 2024 that will close this issue
5 tasks
@HenrikRoosKpa
Copy link
Author

Is verified by our corporate Azure DevOps pipelines. Version 6.0.1 fix this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants