Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show token balances in drop down token list #3002

Closed
2 of 7 tasks
divine-comedian opened this issue Aug 8, 2023 · 37 comments · Fixed by #4415
Closed
2 of 7 tasks

Show token balances in drop down token list #3002

divine-comedian opened this issue Aug 8, 2023 · 37 comments · Fixed by #4415
Assignees
Labels
P2 A normal to do item or feature. UX

Comments

@divine-comedian
Copy link
Contributor

divine-comedian commented Aug 8, 2023

We should update the token list drop down menu on the donate page for a project

  • Users click the drop down menu and now it opens a full modal for them to choose from a list of eligible tokens

image

image

Feature checklist

  • - We show them their token balances right inside the modal
  • - we will need to query their balances for many tokens
  • - the list should then be sorted to show the highest balances at the top of the list
  • - users can click a toggle that hides tokens with zero balances
  • - users see a small logo on top of the token icons that signifies that the given token is givbacks eligible
  • - message at the bottom to inform users that GIVbacks logo means that the token is GIVbacks eligible
  • show states for when token is unselected, highlighted & selected

Figma

https://www.figma.com/file/d3ciTS36toS9mra0RAPMe2/Giveth-Design-System-v0.1?type=design&node-id=5189-12966&mode=design&t=a8nAqx77zJyXDFLx-4

Current flow for handling custom tokens

Screencast.2024-07-03.09.03.50.mp4
@divine-comedian divine-comedian added enhancement New feature or request UX labels Aug 8, 2023
@divine-comedian

This comment was marked as resolved.

@mosaeedi mosaeedi self-assigned this Oct 17, 2023
@mosaeedi

This comment was marked as duplicate.

@mosaeedi

This comment was marked as resolved.

@divine-comedian

This comment was marked as resolved.

@mosaeedi

This comment was marked as resolved.

@RamRamez
Copy link
Collaborator

@mosaeedi I think the Figma link is outdated. Can you please share the new link?

@mosaeedi
Copy link
Collaborator

Sorry, it was moved to another file.

New Figma link

@RamRamez

This comment was marked as outdated.

@divine-comedian
Copy link
Contributor Author

@MohammadPCh has already developed this in "superfluid-develop-branch". I think we can close this issue.
@RamRamez

Do we fetch all the balances in that branch or just the 5 tokens that are superfluid eligible?

Is there anything else we need to build to accommodate using this modal for single donations?

@MoeNick

This comment was marked as outdated.

@MoeNick MoeNick added the P2 A normal to do item or feature. label Jan 18, 2024
@divine-comedian

This comment was marked as outdated.

@MoeNick

This comment was marked as outdated.

@jainkrati jainkrati assigned MohammadPCh and unassigned MoeNick Apr 10, 2024
@jainkrati
Copy link
Collaborator

@MohammadPCh pls take this up and move to QA if already fixed

@MohammadPCh
Copy link
Collaborator

Hey @divine-comedian, do we still support using custom tokens?

@MohammadPCh
Copy link
Collaborator

@divine-comedian how about showing gemini modal for donating GIV to givingBlock projects? do we need it or we can remove them?

@maryjaf
Copy link
Collaborator

maryjaf commented Jul 16, 2024

I see this changes are on staging env but the status of this issue is "inprogress"
Is it ready for testing or not ?
Since we have a release in upcoming days if this issue won't be ready it should be reverted

@divine-comedian
Copy link
Contributor Author

@kkatusic - If you're able to jump in here I will clarify what we need for the release:

fix bug related to showing native token balance when no token is selected.

let's leave out the sorting token balance requirements and work on it after the new version release.

@kkatusic
Copy link
Collaborator

@divine-comedian, I fixed that, please check it here

@divine-comedian
Copy link
Contributor Author

@maryjaf - can you please test this one

@lovelgeorge99
Copy link
Collaborator

@divine-comedian i fixed the sorting based on highest balance here #4416
can you please check

@maryjaf
Copy link
Collaborator

maryjaf commented Jul 17, 2024

Since this issue needs to be tested before release and I'm working on the qf issue now, it would be great if @LatifatAbdullahi has a chance to look into this issue, wdyt? @divine-comedian

@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Jul 17, 2024

Test Update

@divine-comedian

  • We show them their token balances right inside the modal - Pass

  • We will need to query their balances for many tokens - Pass

  • The list should then be sorted to show the highest balances at the top of the list - Fail

  • Users can click a toggle that hides tokens with zero balances - Pass

  • Users see a small logo on top of the token icons that signifies that the given token is Givbacks eligible - Pass

  • Message at the bottom to inform users that GIVbacks logo means that the token is GIVbacks eligible - Pass

  • Show states for when token is unselected - Pass

  • Show states for when token is highlighted - Pass

  • Show states for when token is selected - Pass

  • The list should then be sorted to show the highest balances at the top of the list - Fail

0

image

@kkatusic
Copy link
Collaborator

@LatifatAbdullahi, cc @divine-comedian, please check balance sorting on this PR: here

@LatifatAbdullahi
Copy link

@divine-comedian @kkatusic

Test Update

The list should then be sorted to show the highest balances at the top of the list - Pass

image

image

@kkatusic
Copy link
Collaborator

@LatifatAbdullahi please when you get time can you test this issue task:

  • Users can click a toggle that hides tokens with zero balances

Link for vercel temp link is here

@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Jul 22, 2024

@kkatusic @MohammadPCh
Test Update

Users can click a toggle that hides tokens with zero balances - Test Pass

Before Clicking the check box

image

After clicking the check box

image

@kkatusic
Copy link
Collaborator

@LatifatAbdullahi just to notice here, @MohammadPCh resolved this issue, me and @lovelgeorge99 just fix 2 twings.

But thanks @LatifatAbdullahi to testing all options ;)

@LatifatAbdullahi
Copy link

Alright, noted, thanks

@divine-comedian
Copy link
Contributor Author

@kkatusic - we need to make sure we are testing this on staging and not on feature branches - can you please confirm when this is on staging so it can be tested properly.

@kkatusic
Copy link
Collaborator

@kkatusic - we need to make sure we are testing this on staging and not on feature branches - can you please confirm when this is on staging so it can be tested properly.

sorry @divine-comedian , I thought this is some fast fix for this to be published on Friday, that's why I ask @LatifatAbdullahi to test on feature branch. And also when I close or someone else close pull request this issue automatically, that's why we left it on feature branch.

@kkatusic
Copy link
Collaborator

@LatifatAbdullahi these two fix, about balance order and 0 balance have been merged to staging, when you get time please test, thx.

@LatifatAbdullahi
Copy link

@kkatusic @divine-comedian

Test Update on Staging - Pass

Sorting tokens from highest in quantity to lowest - Pass

Before checking the box to hide tokens with zero balance

image

After checking the box to hide tokens with zero balance

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A normal to do item or feature. UX
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.