-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show token balances in drop down token list #3002
Comments
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@mosaeedi I think the Figma link is outdated. Can you please share the new link? |
Sorry, it was moved to another file. |
This comment was marked as outdated.
This comment was marked as outdated.
Do we fetch all the balances in that branch or just the 5 tokens that are superfluid eligible? Is there anything else we need to build to accommodate using this modal for single donations? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@MohammadPCh pls take this up and move to QA if already fixed |
Hey @divine-comedian, do we still support using custom tokens? |
@divine-comedian how about showing gemini modal for donating GIV to givingBlock projects? do we need it or we can remove them? |
I see this changes are on staging env but the status of this issue is "inprogress" |
@kkatusic - If you're able to jump in here I will clarify what we need for the release: fix bug related to showing native token balance when no token is selected. let's leave out the sorting token balance requirements and work on it after the new version release. |
@divine-comedian, I fixed that, please check it here |
@maryjaf - can you please test this one |
@divine-comedian i fixed the sorting based on highest balance here #4416 |
Since this issue needs to be tested before release and I'm working on the qf issue now, it would be great if @LatifatAbdullahi has a chance to look into this issue, wdyt? @divine-comedian |
Test Update
|
@LatifatAbdullahi, cc @divine-comedian, please check balance sorting on this PR: here |
Test Update The list should then be sorted to show the highest balances at the top of the list - Pass |
@LatifatAbdullahi please when you get time can you test this issue task:
Link for vercel temp link is here |
@kkatusic @MohammadPCh Users can click a toggle that hides tokens with zero balances - Test Pass Before Clicking the check box After clicking the check box |
@LatifatAbdullahi just to notice here, @MohammadPCh resolved this issue, me and @lovelgeorge99 just fix 2 twings. But thanks @LatifatAbdullahi to testing all options ;) |
Alright, noted, thanks |
@kkatusic - we need to make sure we are testing this on staging and not on feature branches - can you please confirm when this is on staging so it can be tested properly. |
sorry @divine-comedian , I thought this is some fast fix for this to be published on Friday, that's why I ask @LatifatAbdullahi to test on feature branch. And also when I close or someone else close pull request this issue automatically, that's why we left it on feature branch. |
@LatifatAbdullahi these two fix, about balance order and 0 balance have been merged to staging, when you get time please test, thx. |
Test Update on Staging - Pass Sorting tokens from highest in quantity to lowest - Pass Before checking the box to hide tokens with zero balance After checking the box to hide tokens with zero balance |
We should update the token list drop down menu on the donate page for a project
Feature checklist
Figma
https://www.figma.com/file/d3ciTS36toS9mra0RAPMe2/Giveth-Design-System-v0.1?type=design&node-id=5189-12966&mode=design&t=a8nAqx77zJyXDFLx-4
Current flow for handling custom tokens
Screencast.2024-07-03.09.03.50.mp4
The text was updated successfully, but these errors were encountered: