Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managing a recurring donation already ongoing. #3092

Closed
11 of 16 tasks
divine-comedian opened this issue Aug 25, 2023 · 18 comments
Closed
11 of 16 tasks

Managing a recurring donation already ongoing. #3092

divine-comedian opened this issue Aug 25, 2023 · 18 comments
Assignees
Labels
P1 it's a blocker to other tasks or issues. SuperFluid

Comments

@divine-comedian
Copy link
Contributor

divine-comedian commented Aug 25, 2023

Donors will need to view and manage their recurring donations from a page accessible from My Donations in a sub-tab called Recurring Donations - the other new sub-tab One-time Donations will contain the current regular donations table view

My recurring donations (1)
https://www.figma.com/file/nVoinu0tgJ565enN5R4WDE/GIVeconomy?type=design&node-id=23293-17833&mode=design&t=7J6iMuXHXGGPhHxz-0

The first component is a table of My Active Streams - this is a list of all super token balances for the given account/donor

this table includes:

The second table below shows each individual recurring donation, this table includes:

  • date stream was created

  • name of project receiving recurring donation

  • network

  • monthly amount of recurring donation

  • when their stream balance will run out for given token*

  • total amount donated to project

  • actions menu

  • *When the token balance is under 1 month remaining we should highlight in red & bold - showing a hover tooltip with the text included in the figma (from View & understand recurring donations being sent to a Project #3093)

actions menu items

for an active stream

for ended stream

  • Renew Donation (creates new recurring donation to project)
  • Archive Donation (removes this row entry from the table)
@jainkrati
Copy link
Collaborator

@MohammadPCh can you please lead this. If needed please distribute sub tasks to @alireza-sharifpour

@jainkrati
Copy link
Collaborator

jainkrati commented Jan 8, 2024

@mohammadranjbarz can you comment on backend efforts here. If required who in the team can work wtih your guidance on this?

@MohammadPCh
Copy link
Collaborator

@jainkrati @divine-comedian, here are the estimations for each task:

  • Streams Balances: Approximately 12 hours (withdraw functionality not finished yet).
  • Donation table: Approximately 20 hours.
  • Action dropdown and modals: Approximately 24 hours.

@divine-comedian divine-comedian added the P1 it's a blocker to other tasks or issues. label Jan 29, 2024
@divine-comedian
Copy link
Contributor Author

@MohammadPCh - do you have any updates for this issue? what is left? what is still blocked by the back-end?

@MohammadPCh
Copy link
Collaborator

@divine-comedian Yes, I am currently waiting for the backend. However, the top section has been implemented.

@divine-comedian divine-comedian changed the title As a Donor, I want to manage a recurring donation I have already ongoing. Managing a recurring donation already ongoing. Feb 5, 2024
@jainkrati jainkrati removed the blocked label Mar 11, 2024
@jainkrati
Copy link
Collaborator

@MohammadPCh and @mohammadranjbarz to sync up and unblock the development

@divine-comedian
Copy link
Contributor Author

Needs Giveth/impact-graph#1398 and Giveth/impact-graph#1400 to proceed.

@divine-comedian
Copy link
Contributor Author

Testing this one I want to make sure we don't forget to update the icons and text color in the actions menus as per the figma!
image

@jainkrati
Copy link
Collaborator

@MohammadPCh pls take up on pirority

@maryjaf
Copy link
Collaborator

maryjaf commented Apr 3, 2024

  • 1- resolved

I haven't seen any changes in action styles in compare of before @MohammadPCh is this the final version?
image.png

@maryjaf
Copy link
Collaborator

maryjaf commented Apr 3, 2024

  • when their stream balance will run out for given token*
  • 2-

based on the description this field " total amount donated to project" should be sown like as below pic in the second table
image

but in current design it is shown like as below pic, is this final and ok ? @divine-comedian @MoeNick
image

@maryjaf
Copy link
Collaborator

maryjaf commented Apr 3, 2024

  • 3-

It hasn't been implemented, I haven't seen this design in my recurring donation list with <1 month , is it in the scop or was removed?

@maryjaf
Copy link
Collaborator

maryjaf commented Apr 3, 2024

4-

  • total amount donated to project

and this item is blocked by this problem that should be checked
Giveth/impact-graph#1437 (comment)

@divine-comedian
Copy link
Contributor Author

@maryjaf the current design on the FE is okay for now.

@maryjaf
Copy link
Collaborator

maryjaf commented Apr 3, 2024

for ended stream

  • Renew Donation (creates new recurring donation to project)
  • Archive Donation (removes this row entry from the table)

should any action be shown for archived donation? I think the action icon should be removed for archive , am I right? @divine-comedian @MohammadPCh

image

@MohammadPCh
Copy link
Collaborator

MohammadPCh commented Apr 4, 2024

@maryjaf I think we have to hide it. I've done it but with new BE changes, it has a problem and shows the actions. so I can hide it again.

@MohammadPCh
Copy link
Collaborator

@divine-comedian @maryjaf What about adding an unarchive option?!

@maryjaf
Copy link
Collaborator

maryjaf commented Apr 4, 2024

should any action be shown for archived donation? I think the action icon should be removed for archive , am I right? @divine-comedian @MohammadPCh

ُThanks @MohammadPCh this problem has been resolved

@maryjaf maryjaf closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 it's a blocker to other tasks or issues. SuperFluid
Projects
None yet
Development

No branches or pull requests

5 participants