-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Donation page UI Improvements #4731
Comments
@mosaeedi these are great just one note for devs:
@mohammadranjbarz can you take this one and implement it along w/ the other GIVbacsk related issues - to be live on prod by Sept 16? :) |
@laurenluz I'm not so fast on FE and not familiar with these pages, so I think I might not deliver it, it's better if some FE developer takes it. |
@RamRamez is working on this today @mohammadranjbarz! Have we set a variable in the backed for minimum USD value for GIVbacks? Or should we hard code the threshold for GIVbacks for now? the minimum donation for GIVbacks eligiblity we communicate to the user should be basically $5 USD... but our actual minimum should be $4 USD... so that (for example) if the user makes a $5 donation to a project and gives 10% of it to Giveth... it still counts. And if the USD value of the token they are donating fluctuates a little below $5 it should still count. So:
|
@laurenluz @RamRamez We don't have any variable for that in the backend, I suggest using hard coded value or put it in the config of FE in Vercel |
|
could you please take a look on below scenario ? @laurenluz when the donation amount is lower than minimum for QF matching in success donation page this box is shown. should it be removed? it's related to this issue #4539 |
For the donation success page box in #4539, let's leave it for now. I'll respond in that other issue and we can address on a later release. For the stellar GIVbacks & QF thing, we'll I'm sort of confused about how this works, and I don't know how to activate GIVbacks for stellar in admin bro 🤔 will DM you @maryjaf |
When the wallet is connected but the token is not selected the input is not how it should be.
|
Why are we still showing these two elements!? We have the mini badges on the top, please remove these two.
|
|
@maryjaf It's not ready to be tested yet! |
Why are we still showing these two elements!? We have the mini badges on the top, please remove these two. Done! cc @maryjaf |
Done! Also donation USD value is added! |
Please take a look here to see how we should tell user about the eligible network for the QF matching. Please note:On Stellar flow, we don't show the Switch network & bridge tokens. |
@maryjaf These sections are ready to be tested! |
Thank @RamRamez , Now if there is no active round, the badge related to QF isn't shown in one time and stellar donation page . |
@maryjaf This section is ready to be tested |
|
|
@maryjaf Done! |
Thanks @RamRamez all problems have been fixed |
So Is this normal that stellar and solana icons isn't shown in this modal? @RamRamez |
@maryjaf I fixed it and now Stellar and Solana icons will be shown but Solana will not be shown in staging because we use different network ids in FE and BE for Solana. You can test after 10 min. |
|
@maryjaf I fixed showing Solana icons and chain names but still it shows Solana as a QF not eligible chain even though Solana is added to QF round, because three IDs are defined (101, 102, 103) for Solana in staging BE and FE. |
There is a problem in switch network but I think it isn't exactly related to this issue and changes, please take a look on below screen records
Screen.Recording.2024-09-24.at.10.06.02.AM.mov
Screen.Recording.2024-09-24.at.10.06.28.AM.mov@MoeNick @RamRamez |
@maryjaf I think it's not related to this issue and my codes. |
On the donation page, we recently added an option to donate with Stellar,
We also need to tell users about minimum donations to make the donation eligible for QF matching and GIVbacks.
It's getting more cluttered and different elements are not working perfectly with each other.
I made these adjustments to enhance the overall user experience during the final step of the donation process.
I've added all the necessary info on Figma to make it as clear as possible, please take a look and in case you find any issues, reach out to me.
Here is the link to Figma.
Regular donation
Stellar donation
CC: @laurenluz
The text was updated successfully, but these errors were encountered: