Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperFluid Notifications for Notification Center #62

Closed
divine-comedian opened this issue Sep 6, 2023 · 25 comments
Closed

SuperFluid Notifications for Notification Center #62

divine-comedian opened this issue Sep 6, 2023 · 25 comments
Assignees

Comments

@divine-comedian
Copy link
Contributor

divine-comedian commented Sep 6, 2023

We will have these notifications on the Notification Center:

Notification Center
https://www.figma.com/file/nVoinu0tgJ565enN5R4WDE/GIVeconomy?type=design&node-id=23293-17833&mode=design&t=V0ZWCYffPNSTpoI7-0

All of these will be fit under the "Project" category in the notification center drop down

EDIT 05/02/2024 - I removed many of the notifications given the challenges of notification center resource consumption

For Donor

On 1 month left in stream balance

"Your Stream Balance of {underlyingTokenSymbol} on {network} will run out in 1 month, top-up here."

Link to my recurring donations tab

On 1 week left in stream balance

"Your Stream Balance of {underlyingTokenSymbol} on {network} will run out in 1 week, top-up here."

Link to my recurring donations tab

When user runs out of stream balance

"Your Stream Balance in {tokenSymbol} on {network} has run out of funds, subsequently some of your recurring donations have ended. Manage your Recurring Donations"

Link to my donations page

For Project Owner

When new recurring donation is created for their project

"Congratulations, your project {projectName} has a new recurring donation."

link to my project page

cc: @MoeNick

@divine-comedian divine-comedian self-assigned this Sep 6, 2023
@divine-comedian divine-comedian changed the title SuperFluid Notifications SuperFluid Notifications for Notification Cente Sep 6, 2023
@divine-comedian divine-comedian changed the title SuperFluid Notifications for Notification Cente SuperFluid Notifications for Notification Center Sep 6, 2023
@divine-comedian divine-comedian transferred this issue from Giveth/giveth-dapps-v2 Oct 6, 2023
@divine-comedian divine-comedian transferred this issue from Giveth/impact-graph Oct 6, 2023
@divine-comedian
Copy link
Contributor Author

@jainkrati - this is another job for the BE - creating the notifications associated with certain actions of recurring donations

@divine-comedian
Copy link
Contributor Author

@CarlosQ96 will add DB entity to notification center - need to make an issue for email journeys related to notifications @divine-comedian

@maryjaf
Copy link

maryjaf commented Apr 3, 2024

When user runs out of stream balance

"Your Stream Balance in {tokenSymbol} on {network} has run out of funds, subsequently some of your recurring donations have ended. Manage your Recurring Donations"

  • 1-

should a notification be sent when user manually ends the recurring donation? @CarlosQ96 @divine-comedian
if yes I didn't receive notification for this

@maryjaf
Copy link

maryjaf commented Apr 3, 2024

For Project Owner

When new recurring donation is created for their project

"Congratulations, your project {projectName} has a new recurring donation."

link to my project page

cc: @MoeNick

  • 2-

when I create new recurring donation , my project owner does not receive a new notification

https://staging.giveth.io/project/testupdate1000?tab=donations
image

project owner:
the last notification is related to a one time donation
https://staging.giveth.io/user/0xcd192b61a8dd586a97592555c1f5709e032f2505
image

@maryjaf
Copy link

maryjaf commented Apr 4, 2024

I didn't receive any notification for recurring donation and I moved it to inprogress for more checking
@CarlosQ96 @jainkrati

@jainkrati jainkrati assigned RamRamez and unassigned CarlosQ96 Apr 4, 2024
@MoeNick
Copy link
Member

MoeNick commented Apr 7, 2024

@RamRamez any updates?

@jainkrati jainkrati changed the title SuperFluid Notifications for Notification Center [Blocked on Staging] SuperFluid Notifications for Notification Center Apr 8, 2024
@divine-comedian
Copy link
Contributor Author

When user runs out of stream balance

"Your Stream Balance in {tokenSymbol} on {network} has run out of funds, subsequently some of your recurring donations have ended. Manage your Recurring Donations"

  • 1-

should a notification be sent when user manually ends the recurring donation? @CarlosQ96 @divine-comedian if yes I didn't receive notification for this

No - the user should not get any notification when they manually end a recurring donation.

@maryjaf
Copy link

maryjaf commented Apr 15, 2024

@divine-comedian
Copy link
Contributor Author

one question @MoeNick @divine-comedian There is no item for this new notifications in "notification setting" https://staging.giveth.io/notifications/settings Tt should be added like other notification or not important for this phase?

Nice catch! Yes they should have an entry in there, allowing the user to control if they receive emails & in-app notifs or not

There should be just one new entry:

Supported project Activity ->

Stream Balance Warnings

'Notify me when any of my Stream Balances are running low'


For recurring donation received we can consider it a part of the existing settings entry for 'Donation received'

@maryjaf
Copy link

maryjaf commented Apr 16, 2024

When user runs out of stream balance

"Your Stream Balance in {tokenSymbol} on {network} has run out of funds, subsequently some of your recurring donations have ended. Manage your Recurring Donations"

Link to my donations page

  • 3- My stream balance runs out but I haven't receive any notification after " runs out after 1 week" notification,
    please take a look @RamRamez

image

@RamRamez
Copy link
Collaborator

one question @MoeNick @divine-comedian There is no item for this new notifications in "notification setting" https://staging.giveth.io/notifications/settings Tt should be added like other notification or not important for this phase?

Nice catch! Yes they should have an entry in there, allowing the user to control if they receive emails & in-app notifs or not

There should be just one new entry:

Supported project Activity ->

Stream Balance Warnings

'Notify me when any of my Stream Balances are running low'

For recurring donation received we can consider it a part of the existing settings entry for 'Donation received'

So we need only one notification but we have three RN. @CarlosQ96 can you please check it?

@RamRamez
Copy link
Collaborator

When user runs out of stream balance

"Your Stream Balance in {tokenSymbol} on {network} has run out of funds, subsequently some of your recurring donations have ended. Manage your Recurring Donations"

Link to my donations page

  • 3- My stream balance runs out but I haven't receive any notification after " runs out after 1 week" notification,
    please take a look @RamRamez

image

We fetch only active recurring donations, and when balance is depleted, the status will be ended. I can change it to fetch all recurring donations, but the problem is we don't know if user has stopped the recurring donation or the donation stream is just depleted. I trying to find a workaround.
@CarlosQ96 do you have any ideas how to figure this out?

@jainkrati jainkrati changed the title [Blocked on Staging] SuperFluid Notifications for Notification Center SuperFluid Notifications for Notification Center Apr 18, 2024
@maryjaf
Copy link

maryjaf commented Apr 18, 2024

one question @MoeNick @divine-comedian There is no item for this new notifications in "notification setting" https://staging.giveth.io/notifications/settings Tt should be added like other notification or not important for this phase?

Nice catch! Yes they should have an entry in there, allowing the user to control if they receive emails & in-app notifs or not

There should be just one new entry:

Supported project Activity ->

Stream Balance Warnings

'Notify me when any of my Stream Balances are running low'

For recurring donation received we can consider it a part of the existing settings entry for 'Donation received'

This item hasn't been resolved yet @RamRamez @CarlosQ96 I'm not sure this should be fixed from backend or frontend side

@maryjaf maryjaf assigned RamRamez and unassigned maryjaf Apr 18, 2024
@maryjaf
Copy link

maryjaf commented Apr 18, 2024

When user runs out of stream balance

"Your Stream Balance in {tokenSymbol} on {network} has run out of funds, subsequently some of your recurring donations have ended. Manage your Recurring Donations"

Link to my donations page

  • 3- My stream balance runs out but I haven't receive any notification after " runs out after 1 week" notification,
    please take a look @RamRamez

image

This problem also hasn’t been resolved yet
Let me know when these 2 problems be resolved

@RamRamez
Copy link
Collaborator

Notification and email for "When user runs out of stream balance" is done and ready to be tested on staging.

@RamRamez
Copy link
Collaborator

RamRamez commented Apr 21, 2024

@maryjaf for testing, when stream is stopped via our UI, we don't send depleted notification, but when it's stopped via SuperFluid UI, we send notif and email.

@maryjaf
Copy link

maryjaf commented Apr 21, 2024

one question @MoeNick @divine-comedian There is no item for this new notifications in "notification setting" https://staging.giveth.io/notifications/settings Tt should be added like other notification or not important for this phase?

Nice catch! Yes they should have an entry in there, allowing the user to control if they receive emails & in-app notifs or not
There should be just one new entry:

Supported project Activity ->

Stream Balance Warnings

'Notify me when any of my Stream Balances are running low'
For recurring donation received we can consider it a part of the existing settings entry for 'Donation received'

This item hasn't been resolved yet @RamRamez @CarlosQ96 I'm not sure this should be fixed from backend or frontend side

And what a bout this problem? @RamRamez

@RamRamez
Copy link
Collaborator

one question @MoeNick @divine-comedian There is no item for this new notifications in "notification setting" https://staging.giveth.io/notifications/settings Tt should be added like other notification or not important for this phase?

Nice catch! Yes they should have an entry in there, allowing the user to control if they receive emails & in-app notifs or not
There should be just one new entry:

Supported project Activity ->

Stream Balance Warnings

'Notify me when any of my Stream Balances are running low'
For recurring donation received we can consider it a part of the existing settings entry for 'Donation received'

This item hasn't been resolved yet @RamRamez @CarlosQ96 I'm not sure this should be fixed from backend or frontend side

And what a bout this problem? @RamRamez

I checked and we have three notifications in DB for Superfluid but we should show only one in FE. I'm not sure how can we handle this. @CarlosQ96 can you take a look?

@divine-comedian
Copy link
Contributor Author

To clarify here for you both @RamRamez @CarlosQ96

The three "balance warning notificiations", 1 month warning, 1 week warning & ended should be toggled on/off with one entry on the FE

The recurring donation received should be toggled on/off by this same existing entry:

image

@maryjaf
Copy link

maryjaf commented Apr 24, 2024

I haven't seen any changed in notification setting page @RamRamez
image

@RamRamez
Copy link
Collaborator

@maryjaf it's placed in the supported project activity as it was requested by Mitch in this issue
image

@maryjaf
Copy link

maryjaf commented Apr 24, 2024

Thanks @RamRamez This issue has been resolved

@maryjaf maryjaf closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants