Add consistent checks for arguments of coregistration classes #575
Labels
architecture
Need to re-organize or re-structure something
enhancement
Feature improvement or request
Not a big priority, but right now inputs of coregistration classes are inconsistently checked, which can yield in some cases non-user friendly error messages if they are wrongly defined (even though the type hinting should provide some clarity for the user when that is the case).
We should add checks similar to the
_check_inputs_bin_before_fit
used only inNuthKaab
in affine (for now), and the checks inBiasCorr.__init__
which check the "fit_or_bin" parameters, for all types of input.Currently the
subsample
argument is checked but only once it runs throughfit()
, while it would be better to have an error raised straight at class instantiation (=when it is defined). Andrandom_state
is not checked at all.The text was updated successfully, but these errors were encountered: