Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consistent checks for arguments of coregistration classes #575

Open
rhugonnet opened this issue Aug 30, 2024 · 0 comments
Open

Add consistent checks for arguments of coregistration classes #575

rhugonnet opened this issue Aug 30, 2024 · 0 comments
Labels
architecture Need to re-organize or re-structure something enhancement Feature improvement or request

Comments

@rhugonnet
Copy link
Contributor

Not a big priority, but right now inputs of coregistration classes are inconsistently checked, which can yield in some cases non-user friendly error messages if they are wrongly defined (even though the type hinting should provide some clarity for the user when that is the case).

We should add checks similar to the _check_inputs_bin_before_fit used only in NuthKaab in affine (for now), and the checks in BiasCorr.__init__ which check the "fit_or_bin" parameters, for all types of input.
Currently the subsample argument is checked but only once it runs through fit(), while it would be better to have an error raised straight at class instantiation (=when it is defined). And random_state is not checked at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Need to re-organize or re-structure something enhancement Feature improvement or request
Projects
None yet
Development

No branches or pull requests

1 participant