Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cover device in Z2M integration #1541

Closed
VonOx opened this issue May 25, 2022 · 9 comments
Closed

Handle cover device in Z2M integration #1541

VonOx opened this issue May 25, 2022 · 9 comments

Comments

@VonOx
Copy link
Contributor

VonOx commented May 25, 2022

Cover devices not handle right now

Exemple expose: CCT5015

{
exposes: [
            {
               features: [
                  {
                     access: 3,
                     name: "state",
                     property: "state",
                     type: "enum",
                     values: [
                        "OPEN",
                        "CLOSE",
                        "STOP"
                     ]
                  },
                  {
                     access: 7,
                     description: "Position of this cover",
                     name: "position",
                     property: "position",
                     type: "numeric",
                     value_max: 100,
                     value_min: 0
                  }
               ],
               type: "cover"
            },
            {
               access: 3,
               description: "Duration of lift",
               name: "lift_duration",
               property: "lift_duration",
               type: "numeric",
               unit: "seconds",
               value_max: 300,
               value_min: 0
            },
            {
               access: 1,
               description: "Link quality (signal strength)",
               name: "linkquality",
               property: "linkquality",
               type: "numeric",
               unit: "lqi",
               value_max: 255,
               value_min: 0
            }
         ]
}
@atrovato
Copy link
Contributor

Related to atrovato#39
And #1456 (with picture)

I had some questions:

  1. I don't think UP/DOWN buttons are the good choice, we may have LEFT/RIGHT too, so maybe we should have OPEN/CLOSE?
  2. Do you think we should have 2 separated devices, shutter and curtain?

@VonOx
Copy link
Contributor Author

VonOx commented May 26, 2022

  1. I think every day we say "I will open cover" so I agree for OPEN/CLOSE

  2. Yes two devices, 2 separate icons in front 😉

@atrovato
Copy link
Contributor

I didn't found the right icon in feathericons

Here a preview

image

@atrovato atrovato mentioned this issue Jul 24, 2022
6 tasks
@stale
Copy link

stale bot commented Jul 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 26, 2022
@atrovato
Copy link
Contributor

Waiting for testers with atrovato/gladys:zigbee2mqtt-cover

@stale
Copy link

stale bot commented Sep 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 29, 2022
@atrovato
Copy link
Contributor

PR is pending, validated by the community.

@stale stale bot removed the stale label Sep 29, 2022
@atrovato
Copy link
Contributor

atrovato commented Oct 3, 2022

So? Is it ok now?

@Pierre-Gilles
Copy link
Contributor

Yes this is merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants