improve condition in launcher #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR! I just answered on the forum => https://community.gladysproject.com/t/evolution-de-la-page-condition-dans-la-creation-des-scenarios/3140/7 |
|
Hey! Thanks for your PR, the feature is really nice 👍 I just merged it, but one feedback: Please write some tests 🙏 I had to write tests myself to test if your feature was working properly! Here is the kind of test expected :
I had to write many fixtures to write a consistent test, it's important! |
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a trueIf field in state so that when a condition in a launcher is added, the user can either choose the condition to be true if state are true, or true if state are false.