-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does nothing to incomplete HTML #1185
Comments
Please follow the issue template provided. More specifically, adding a link to the required |
/cc @prettydiff in case the beautifier being used is Pretty Diff. |
Ah I just realized I'm using a |
@Glavin001 Why doesn't the HTML in PHP files get beautified? Am I missing a setting or is this feature missing? |
The PHP beautifiers don't appear to support HTML and then the HTML beautifiers don't support PHP.
I am working on rewriting Atom-Beautify using a new core library, Unibeautify, which I plan to have a way to beautify HTML and PHP both separately, with their respective beautifiers, and merge the result back together. |
Could you not just run the HTML beautifier after the PHP one? I doubt I've exhaustively tried every eventuality but from my testing it seems to work well enough. The php tags should just be treated as a normal HTML tag from what I can see. An option in the PHP settings to also trigger a HTML beautification would be awesome. Glad to hear it's being worked on though. |
Yeah I described the wrong feature 😜. There is one new feature for running a list of beautifiers (such as PHP then HTML or two different JavaScript beautifiers, etc) and another more complex feature for languages like Vue ( #722 ) that will detect different pieces as different languages and apply the appropriate beautifier. Regardless, languages such as PHP should be seeing an improvement in future releases, once I am done with developing Unibeautify v1. |
@JamesCoyle I recently extended the js parser in Pretty Diff to support C#, Java, and TypeScript. It is not currently on my agenda, but I could also extended it to support PHP. |
It seems that any HTML files without the html or body tags do not get beautified. It would be nice if they were appropriately indented regardless of whether they are fully formed HTML documents or not.
The text was updated successfully, but these errors were encountered: