Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PHP Coding Standards Fixer #242

Merged
merged 4 commits into from
Mar 20, 2015
Merged

Conversation

flippedbits
Copy link
Contributor

In reference to #175 I have removed PHP_Beautifier and replaced it with php-cs-fixer. This is my first attempt at working with an atom package, so hopefully I did everything correctly.

@Glavin001
Copy link
Owner

Awesome, thank you!

I am going to try to personally review this Pull Request soon (tomorrow or this weekend). First, could you enable the PHP unit tests:

This will mean that PHP beautification is now supported with tests and is tested by Travis CI automatically.

Thanks again! Awesome work so far.

enable test 1 and 2.
test 3 does not seem to pass
@Glavin001
Copy link
Owner

Looks good to me! Absolutely awesome work!

Glavin001 added a commit that referenced this pull request Mar 20, 2015
Switch to PHP Coding Standards Fixer
@Glavin001 Glavin001 merged commit 95dfabe into Glavin001:master Mar 20, 2015
@Glavin001
Copy link
Owner

Published to v0.23.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants