Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When eye gaze is not enabled, we get errors when action map contains eye gaze interaction #86

Closed
BastiaanOlij opened this issue Feb 4, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@BastiaanOlij
Copy link
Member

The action map logic in Godot is build in such a way that all interactions can be added to the action map provided the entries appear in the meta data. The action map logic will then filter out unsupported bindings on load.

The problem with our eye gaze extension is that when it's not enabled, we don't instantiate the class at all, leading to errors when we're trying to load action maps that contain the eye gaze interaction:

modules/openxr/editor/openxr_interaction_profile_editor.cpp:260 - Parameter "profile_def" is null.

In situations where extensions introduce meta data for the action map system, we should probably make an exception and instance the class, but skip trying to activate the extension.

@BastiaanOlij BastiaanOlij added the bug Something isn't working label Feb 4, 2024
@m4gr3d m4gr3d added this to the 3.0.0 milestone Feb 6, 2024
@BastiaanOlij
Copy link
Member Author

Should be resolved by godotengine/godot#88754

@m4gr3d m4gr3d closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants