Reuse existing tab fallback (for Chrome headless)

GoogleChrome · Jul 9, 2016 · 27d3ed8 · 27d3ed8
1 parent 466beff
commit 27d3ed8
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lighthouse-core/driver/drivers/cri.js b/lighthouse-core/driver/drivers/cri.js
@@ -38,7 +38,7 @@ class CriDriver extends Driver {
       /* eslint-disable new-cap */
       chromeRemoteInterface.New((err, tab) => {
         if (err) {
-          return reject(err);
+          log.warn('CRI driver', 'cannot create new tab, will reuse tab.', err);
         }
 
         chromeRemoteInterface({port: port, chooseTab: tab}, chrome => {
@@ -57,6 +57,7 @@ class CriDriver extends Driver {
   disconnect() {
     return new Promise((resolve, reject) => {
       if (!this._tab) {
+        this._chrome.close();
         return resolve();
       }