From 3f4b61de4df8b08de3f19abbeeef7cf141f9d8e7 Mon Sep 17 00:00:00 2001
From: Connor Clark <cjamcl@google.com>
Date: Mon, 1 Apr 2024 12:49:32 -0700
Subject: [PATCH] core(a11y): re-enable target-size hidden audit (#15888)

---
 cli/test/smokehouse/test-definitions/a11y.js  | 55 +++++++++----------
 core/gather/gatherers/accessibility.js        |  3 +-
 .../gather/gatherers/accessibility-test.js    |  2 -
 3 files changed, 28 insertions(+), 32 deletions(-)

diff --git a/cli/test/smokehouse/test-definitions/a11y.js b/cli/test/smokehouse/test-definitions/a11y.js
index 1a1393878e82..6418422cae5b 100644
--- a/cli/test/smokehouse/test-definitions/a11y.js
+++ b/cli/test/smokehouse/test-definitions/a11y.js
@@ -930,34 +930,33 @@ const expectations = {
           ],
         },
       },
-      // TODO: https://github.com/GoogleChrome/lighthouse/issues/15824
-      // 'target-size': {
-      //   score: 1,
-      //   details: {
-      //     items: [
-      //       {
-      //         node: {
-      //           'type': 'node',
-      //           'selector': 'body > section > button#target-size-1',
-      //           'snippet': '<button id="target-size-1">',
-      //           // Exact target size can vary depending on the device.
-      //           'explanation': /^Fix any of the following:\n {2}Target has insufficient size \([0-9.]+px by [0-9.]+px, should be at least 24px by 24px\)\n {2}Target has insufficient space to its closest neighbors. Safe clickable space has a diameter of [0-9.]+px instead of at least 24px\.$/,
-      //           'nodeLabel': '+',
-      //         },
-      //       },
-      //       {
-      //         node: {
-      //           'type': 'node',
-      //           'selector': 'body > section > span#target-size-2',
-      //           'snippet': '<span role="button" tabindex="0" id="target-size-2">',
-      //           // Exact target size can vary depending on the device.
-      //           'explanation': /^Fix any of the following:\n {2}Target has insufficient size \([0-9.]+px by [0-9.]+px, should be at least 24px by 24px\)\n {2}Target has insufficient space to its closest neighbors. Safe clickable space has a diameter of [0-9.]+px instead of at least 24px\.$/,
-      //           'nodeLabel': 'o',
-      //         },
-      //       },
-      //     ],
-      //   },
-      // },
+      'target-size': {
+        score: 1,
+        details: {
+          items: [
+            {
+              node: {
+                'type': 'node',
+                'selector': 'body > section > button#target-size-1',
+                'snippet': '<button id="target-size-1">',
+                // Exact target size can vary depending on the device.
+                'explanation': /^Fix any of the following:\n {2}Target has insufficient size \([0-9.]+px by [0-9.]+px, should be at least 24px by 24px\)\n {2}Target has insufficient space to its closest neighbors. Safe clickable space has a diameter of [0-9.]+px instead of at least 24px\.$/,
+                'nodeLabel': '+',
+              },
+            },
+            {
+              node: {
+                'type': 'node',
+                'selector': 'body > section > span#target-size-2',
+                'snippet': '<span role="button" tabindex="0" id="target-size-2">',
+                // Exact target size can vary depending on the device.
+                'explanation': /^Fix any of the following:\n {2}Target has insufficient size \([0-9.]+px by [0-9.]+px, should be at least 24px by 24px\)\n {2}Target has insufficient space to its closest neighbors. Safe clickable space has a diameter of [0-9.]+px instead of at least 24px\.$/,
+                'nodeLabel': 'o',
+              },
+            },
+          ],
+        },
+      },
       'td-has-header': {
         score: 0,
         details: {
diff --git a/core/gather/gatherers/accessibility.js b/core/gather/gatherers/accessibility.js
index 4a17f8479baf..d3a94705286a 100644
--- a/core/gather/gatherers/accessibility.js
+++ b/core/gather/gatherers/accessibility.js
@@ -79,8 +79,7 @@ async function runA11yChecks() {
       'tabindex': {enabled: true},
       'table-duplicate-name': {enabled: true},
       'table-fake-caption': {enabled: true},
-      // TODO: https://github.com/GoogleChrome/lighthouse/issues/15824
-      // 'target-size': {enabled: true},
+      'target-size': {enabled: true},
       'td-has-header': {enabled: true},
     },
   });
diff --git a/core/test/gather/gatherers/accessibility-test.js b/core/test/gather/gatherers/accessibility-test.js
index 195a5a2f32ae..4a6149fcf756 100644
--- a/core/test/gather/gatherers/accessibility-test.js
+++ b/core/test/gather/gatherers/accessibility-test.js
@@ -71,8 +71,6 @@ describe('a11y audits + aXe', () => {
     // Note: audit ids match their filenames, thx to the getAuditList test in runner-test.js
     const filenames = fs.readdirSync(`${LH_ROOT}/core/audits/accessibility/`)
         .map(f => f.replace('.js', ''))
-        // TODO: https://github.com/GoogleChrome/lighthouse/issues/15824
-        .filter(f => f !== 'target-size')
         .filter(f => f !== 'axe-audit' && f !== 'manual');
 
     // 4. Compare. (Received from aXe, Expected is LH audits)