Skip to content

Commit

Permalink
emulation comment: can remove injectedTouchEventsFunction in October (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
paulirish authored and patrickhulce committed Aug 11, 2017
1 parent 618a678 commit a6b71c9
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lighthouse-core/lib/emulation.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ const CPU_THROTTLE_METRICS = {
};

function enableNexus5X(driver) {
// COMPAT FIMXE
// Injecting this function clientside is no longer neccessary as of m62. This is done
// on the backend when `Emulation.setTouchEmulationEnabled` is set.
// https://bugs.chromium.org/p/chromium/issues/detail?id=133915#c63
// Once m62 hits stable (~Oct 20th) we can nuke this entirely
/**
* Finalizes touch emulation by enabling `"ontouchstart" in window` feature detect
* to work. Messy hack, though copied verbatim from DevTools' emulation/TouchModel.js
Expand Down

0 comments on commit a6b71c9

Please sign in to comment.