From c56c97b1dc3793aad64af6153fc602b765bb0e26 Mon Sep 17 00:00:00 2001 From: Paul Irish Date: Fri, 6 Oct 2017 15:42:16 -0700 Subject: [PATCH] test(smokehouse): Passive event listener violation doesn't report on passive:false now (#3498) --- lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html | 2 +- .../test/smokehouse/dobetterweb/dbw-expectations.js | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html b/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html index 051603d54114..a99969298073 100644 --- a/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html +++ b/lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html @@ -209,7 +209,7 @@

Do better web tester page

console.log('touchstart'); }); - // FAIL + // PASS - passive:false doesn't get a warning now. crbug.com/770208 window.addEventListener('mousewheel', function(e) { console.log('mousewheel'); }, {passive: false}); diff --git a/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js b/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js index 314fe18622e8..f027f8fc7bf6 100644 --- a/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js +++ b/lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js @@ -156,9 +156,11 @@ module.exports = [ score: false, extendedInfo: { value: { - // Note: This would normally be 7 but M56 defaults document-level + // Note: Originally this was 7 but M56 defaults document-level // listeners to passive. See https://www.chromestatus.com/features/5093566007214080 - length: 4, + // Note: It was 4, but {passive:false} doesn't get a warning as of M63: crbug.com/770208 + // COMPAT: This can be set to 3 when m63 is stable. + length: '>=3', }, }, },