From d2b6b34689adbc173028edb8be4e5dd6a7071c32 Mon Sep 17 00:00:00 2001 From: Paul Irish Date: Mon, 5 Nov 2018 08:39:03 -0800 Subject: [PATCH] ward feedback --- lighthouse-core/report/html/report-styles.css | 5 +++++ .../report/html/third_party/details-element-polyfill.js | 8 -------- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/lighthouse-core/report/html/report-styles.css b/lighthouse-core/report/html/report-styles.css index 452b3ed92ce1..44efd2618d23 100644 --- a/lighthouse-core/report/html/report-styles.css +++ b/lighthouse-core/report/html/report-styles.css @@ -148,6 +148,11 @@ display: none !important; } +/* Edge doesn't recognize these, and the polyfill doesn't set block. https://github.com/javan/details-element-polyfill/issues/13 */ +details, summary { + display: block; +} + .lh-root details > summary { cursor: pointer; } diff --git a/lighthouse-core/report/html/third_party/details-element-polyfill.js b/lighthouse-core/report/html/third_party/details-element-polyfill.js index ab768957fc91..c7520c76e48c 100644 --- a/lighthouse-core/report/html/third_party/details-element-polyfill.js +++ b/lighthouse-core/report/html/third_party/details-element-polyfill.js @@ -3,10 +3,6 @@ Details Element Polyfill 2.0.4 Copyright © 2018 Javan Makhmali */ -(function() { - - -}).call(this); (function() { var addAttributesForSummary, eventIsSignificant, findClosestElementWithTagName, findElementsWithTagName, onTogglingTrigger, polyfillFocusAndARIA, polyfillProperties, polyfillStyles, polyfillToggle, polyfillToggleEvent, support, triggerToggle, triggerToggleIfToggled; @@ -290,8 +286,4 @@ Copyright © 2018 Javan Makhmali polyfillToggleEvent(); } -}).call(this); -(function() { - - }).call(this);