From da35caa6c0be69d8611c3a5b5034d67eddbb1d3d Mon Sep 17 00:00:00 2001 From: Artur Mizera Date: Wed, 18 Oct 2017 22:56:32 +0200 Subject: [PATCH] misc(audits): removed unused audit meta.category (#3554) --- docs/recipes/custom-audit/searchable-audit.js | 1 - lighthouse-cli/types/types.ts | 1 - .../audits/accessibility/accesskeys.js | 1 - .../audits/accessibility/aria-allowed-attr.js | 1 - .../accessibility/aria-required-attr.js | 1 - .../accessibility/aria-required-children.js | 1 - .../accessibility/aria-required-parent.js | 1 - .../audits/accessibility/aria-roles.js | 1 - .../accessibility/aria-valid-attr-value.js | 1 - .../audits/accessibility/aria-valid-attr.js | 1 - .../audits/accessibility/audio-caption.js | 1 - .../audits/accessibility/button-name.js | 1 - .../audits/accessibility/bypass.js | 1 - .../audits/accessibility/color-contrast.js | 1 - .../audits/accessibility/definition-list.js | 1 - .../audits/accessibility/dlitem.js | 1 - .../audits/accessibility/document-title.js | 1 - .../audits/accessibility/duplicate-id.js | 1 - .../audits/accessibility/frame-title.js | 1 - .../audits/accessibility/html-has-lang.js | 1 - .../audits/accessibility/html-lang-valid.js | 1 - .../audits/accessibility/image-alt.js | 1 - .../audits/accessibility/input-image-alt.js | 1 - lighthouse-core/audits/accessibility/label.js | 1 - .../audits/accessibility/layout-table.js | 1 - .../audits/accessibility/link-name.js | 1 - lighthouse-core/audits/accessibility/list.js | 1 - .../audits/accessibility/listitem.js | 1 - .../audits/accessibility/meta-refresh.js | 1 - .../audits/accessibility/meta-viewport.js | 1 - .../audits/accessibility/object-alt.js | 1 - .../audits/accessibility/tabindex.js | 1 - .../audits/accessibility/td-headers-attr.js | 1 - .../audits/accessibility/th-has-data-cells.js | 1 - .../audits/accessibility/valid-lang.js | 1 - .../audits/accessibility/video-caption.js | 1 - .../audits/accessibility/video-description.js | 1 - lighthouse-core/audits/audit.js | 1 - .../byte-efficiency/offscreen-images.js | 1 - .../byte-efficiency/total-byte-weight.js | 1 - .../byte-efficiency/unused-css-rules.js | 1 - .../byte-efficiency/unused-javascript.js | 1 - .../byte-efficiency/uses-optimized-images.js | 1 - .../uses-request-compression.js | 1 - .../byte-efficiency/uses-responsive-images.js | 1 - .../byte-efficiency/uses-webp-images.js | 1 - lighthouse-core/audits/cache-start-url.js | 1 - .../audits/consistently-interactive.js | 1 - lighthouse-core/audits/content-width.js | 1 - .../audits/critical-request-chains.js | 1 - lighthouse-core/audits/deprecations.js | 1 - .../audits/dobetterweb/appcache-manifest.js | 1 - .../audits/dobetterweb/dom-size.js | 1 - .../external-anchors-use-rel-noopener.js | 1 - .../dobetterweb/geolocation-on-start.js | 1 - .../dobetterweb/link-blocking-first-paint.js | 1 - .../audits/dobetterweb/no-document-write.js | 1 - .../audits/dobetterweb/no-mutation-events.js | 1 - .../audits/dobetterweb/no-old-flexbox.js | 1 - .../dobetterweb/no-vulnerable-libraries.js | 1 - .../audits/dobetterweb/no-websql.js | 1 - .../dobetterweb/notification-on-start.js | 1 - .../password-inputs-can-be-pasted-into.js | 1 - .../script-blocking-first-paint.js | 1 - .../audits/dobetterweb/uses-http2.js | 1 - .../uses-passive-event-listeners.js | 1 - lighthouse-core/audits/errors-in-console.js | 1 - .../audits/estimated-input-latency.js | 1 - lighthouse-core/audits/first-interactive.js | 1 - .../audits/first-meaningful-paint.js | 1 - lighthouse-core/audits/image-aspect-ratio.js | 1 - lighthouse-core/audits/is-on-https.js | 1 - .../audits/load-fast-enough-for-pwa.js | 1 - .../audits/manifest-short-name-length.js | 1 - .../audits/manual/pwa-cross-browser.js | 1 - .../audits/manual/pwa-each-page-has-url.js | 1 - .../audits/manual/pwa-page-transitions.js | 1 - lighthouse-core/audits/predictive-perf.js | 1 - lighthouse-core/audits/redirects-http.js | 1 - lighthouse-core/audits/redirects.js | 1 - .../audits/screenshot-thumbnails.js | 1 - .../audits/seo/http-status-code.js | 1 - .../audits/seo/meta-description.js | 1 - lighthouse-core/audits/service-worker.js | 1 - lighthouse-core/audits/speed-index-metric.js | 1 - lighthouse-core/audits/splash-screen.js | 1 - lighthouse-core/audits/themed-omnibox.js | 1 - lighthouse-core/audits/time-to-first-byte.js | 1 - lighthouse-core/audits/user-timings.js | 1 - lighthouse-core/audits/viewport.js | 1 - .../audits/webapp-install-banner.js | 1 - lighthouse-core/audits/without-javascript.js | 1 - lighthouse-core/audits/works-offline.js | 1 - lighthouse-core/closure/typedefs/Audit.js | 3 -- .../closure/typedefs/AuditResult.js | 3 -- lighthouse-core/config/config.js | 4 --- .../audits/accessibility/axe-audit-test.js | 1 - .../test/audits/manual-audit-test.js | 1 - lighthouse-core/test/config/config-test.js | 6 ---- .../fixtures/invalid-audits/missing-audit.js | 1 - .../invalid-audits/missing-category.js | 28 ------------------- .../invalid-audits/missing-description.js | 1 - .../missing-generate-audit-result.js | 1 - .../invalid-audits/missing-help-text.js | 1 - .../fixtures/invalid-audits/missing-name.js | 1 - .../missing-required-artifacts.js | 1 - .../fixtures/invalid-audits/require-error.js | 1 - .../test/fixtures/valid-custom-audit.js | 1 - lighthouse-core/test/index-test.js | 1 - lighthouse-core/test/runner-test.js | 1 - 110 files changed, 149 deletions(-) delete mode 100644 lighthouse-core/test/fixtures/invalid-audits/missing-category.js diff --git a/docs/recipes/custom-audit/searchable-audit.js b/docs/recipes/custom-audit/searchable-audit.js index 083ecbf11bbd..f79de44897ab 100644 --- a/docs/recipes/custom-audit/searchable-audit.js +++ b/docs/recipes/custom-audit/searchable-audit.js @@ -17,7 +17,6 @@ const MAX_SEARCHABLE_TIME = 4000; class LoadAudit extends Audit { static get meta() { return { - category: 'MyCustomCategory', name: 'searchable-audit', description: 'Search box initialized and ready', failureDescription: 'Search box slow to initialize', diff --git a/lighthouse-cli/types/types.ts b/lighthouse-cli/types/types.ts index 799bdbae40f6..f1bb8c9111cc 100644 --- a/lighthouse-cli/types/types.ts +++ b/lighthouse-cli/types/types.ts @@ -20,7 +20,6 @@ interface AuditFullResult { error?: boolean; description: string; name: string; - category: string; helpText?: string; extendedInfo?: {value: string}; } diff --git a/lighthouse-core/audits/accessibility/accesskeys.js b/lighthouse-core/audits/accessibility/accesskeys.js index 1368a74e4489..6773382c7c17 100644 --- a/lighthouse-core/audits/accessibility/accesskeys.js +++ b/lighthouse-core/audits/accessibility/accesskeys.js @@ -18,7 +18,6 @@ class Accesskeys extends AxeAudit { */ static get meta() { return { - category: 'Accessibility', name: 'accesskeys', description: '`[accesskey]` values are unique.', failureDescription: '`[accesskey]` values are not unique.', diff --git a/lighthouse-core/audits/accessibility/aria-allowed-attr.js b/lighthouse-core/audits/accessibility/aria-allowed-attr.js index ba44a1b7ac2d..1593ad64b45e 100644 --- a/lighthouse-core/audits/accessibility/aria-allowed-attr.js +++ b/lighthouse-core/audits/accessibility/aria-allowed-attr.js @@ -18,7 +18,6 @@ class ARIAAllowedAttr extends AxeAudit { */ static get meta() { return { - category: 'Accessibility', name: 'aria-allowed-attr', description: '`[aria-*]` attributes match their roles.', failureDescription: '`[aria-*]` attributes do not match their roles.', diff --git a/lighthouse-core/audits/accessibility/aria-required-attr.js b/lighthouse-core/audits/accessibility/aria-required-attr.js index 686f7291fc1e..3077ae3fe007 100644 --- a/lighthouse-core/audits/accessibility/aria-required-attr.js +++ b/lighthouse-core/audits/accessibility/aria-required-attr.js @@ -18,7 +18,6 @@ class ARIARequiredAttr extends AxeAudit { */ static get meta() { return { - category: 'Accessibility', name: 'aria-required-attr', description: '`[role]`s have all required `[aria-*]` attributes.', failureDescription: '`[role]`s do not have all required `[aria-*]` attributes.', diff --git a/lighthouse-core/audits/accessibility/aria-required-children.js b/lighthouse-core/audits/accessibility/aria-required-children.js index feb78a327ccc..7f562bf99962 100644 --- a/lighthouse-core/audits/accessibility/aria-required-children.js +++ b/lighthouse-core/audits/accessibility/aria-required-children.js @@ -19,7 +19,6 @@ class AriaRequiredChildren extends AxeAudit { */ static get meta() { return { - category: 'Accessibility', name: 'aria-required-children', description: 'Elements with `[role]` that require specific children `[role]`s, are present.', failureDescription: 'Elements with `[role]` that require specific children `[role]`s, ' + diff --git a/lighthouse-core/audits/accessibility/aria-required-parent.js b/lighthouse-core/audits/accessibility/aria-required-parent.js index d8d6e35788d7..753a6a1d55cd 100644 --- a/lighthouse-core/audits/accessibility/aria-required-parent.js +++ b/lighthouse-core/audits/accessibility/aria-required-parent.js @@ -19,7 +19,6 @@ class AriaRequiredParent extends AxeAudit { */ static get meta() { return { - category: 'Accessibility', name: 'aria-required-parent', description: '`[role]`s are contained by their required parent element.', failureDescription: '`[role]`s are not contained by their required parent element.', diff --git a/lighthouse-core/audits/accessibility/aria-roles.js b/lighthouse-core/audits/accessibility/aria-roles.js index be4050a9679a..80887286f45d 100644 --- a/lighthouse-core/audits/accessibility/aria-roles.js +++ b/lighthouse-core/audits/accessibility/aria-roles.js @@ -18,7 +18,6 @@ class AriaRoles extends AxeAudit { */ static get meta() { return { - category: 'Accessibility', name: 'aria-roles', description: '`[role]` values are valid.', failureDescription: '`[role]` values are not valid.', diff --git a/lighthouse-core/audits/accessibility/aria-valid-attr-value.js b/lighthouse-core/audits/accessibility/aria-valid-attr-value.js index 727e7e8a82b0..8de80c6be402 100644 --- a/lighthouse-core/audits/accessibility/aria-valid-attr-value.js +++ b/lighthouse-core/audits/accessibility/aria-valid-attr-value.js @@ -18,7 +18,6 @@ class ARIAValidAttr extends AxeAudit { */ static get meta() { return { - category: 'Accessibility', name: 'aria-valid-attr-value', description: '`[aria-*]` attributes have valid values.', failureDescription: '`[aria-*]` attributes do not have valid values.', diff --git a/lighthouse-core/audits/accessibility/aria-valid-attr.js b/lighthouse-core/audits/accessibility/aria-valid-attr.js index 973a241657aa..d9935a40b2ce 100644 --- a/lighthouse-core/audits/accessibility/aria-valid-attr.js +++ b/lighthouse-core/audits/accessibility/aria-valid-attr.js @@ -18,7 +18,6 @@ class ARIAValidAttr extends AxeAudit { */ static get meta() { return { - category: 'Accessibility', name: 'aria-valid-attr', description: '`[aria-*]` attributes are valid and not misspelled.', failureDescription: '`[aria-*]` attributes are not valid or misspelled.', diff --git a/lighthouse-core/audits/accessibility/audio-caption.js b/lighthouse-core/audits/accessibility/audio-caption.js index 3f253a1b1dd7..d0f5e01b6c26 100644 --- a/lighthouse-core/audits/accessibility/audio-caption.js +++ b/lighthouse-core/audits/accessibility/audio-caption.js @@ -18,7 +18,6 @@ class AudioCaption extends AxeAudit { */ static get meta() { return { - category: 'Accessibility', name: 'audio-caption', description: '`