InstallabilityErrors protocol format changed

[patrickhulce]

The artifact shape does not match the typedef

Actual (taken from latest-run/artifacts.json)

  "InstallabilityErrors": {
    "installabilityErrors": [
      {
        "errorId": "no-matching-service-worker",
        "errorArguments": []
      }
    ]
  },

Declared

        export interface GetInstallabilityErrorsResponse {
            errors: string[];
        }

Provide the steps to reproduce

1. Run LH on https://www.optyx.app

What is the current behavior?

PWA category errors with ? score

What is the expected behavior?

PWA category displays that the site is not a PWA

Environment Information

• Affected Channels: CLI
• Lighthouse version: master
• Chrome version: 82.0.4054.0

Related issues
It appears that the team's doc (#10168 (comment)) might not have been true afterall :/

[connorjclark]

/cc @chruxin

The strings that are currently present in installable_logging.cc will be
moved to the DevTools frontend. They'll remain in place so we are backwards
compatible.

They should be on the protocol. I'll double check something silly isn't happening in Lighthouse. EDIT: nope ..

[connorjclark]

This is why: https://chromium-review.googlesource.com/c/chromium/src/+/2026381

P0 b/c release blocking.

[connorjclark]

We'll need to support both now.