Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected aggressive-promise-polyfill error on dbwtester #11803

Closed
paulirish opened this issue Dec 9, 2020 · 7 comments · Fixed by #11836
Closed

Unexpected aggressive-promise-polyfill error on dbwtester #11803

paulirish opened this issue Dec 9, 2020 · 7 comments · Fixed by #11836
Labels
needs-priority

Comments

@paulirish
Copy link
Member

This has come up in some smoketests recently......
image

It's entirely clear where it's from. Seems to only happen on ToT.

Me and @brendankenny can repro locally:

image

My repro:

there's a lot of unknowns here..

I'm going to bypass the error temporarily in #11799
@brendankenny
Copy link
Member

This is my minimal version of dbw_tester.html that repros. All parts seem necessary (though refresh+cache might be fooling me on some of it):

<!doctype html>

<html>

<!-- If just this removed (or moved after jquery), will `Aw, Snap!` Chrome 89.0.4351.0. Removing any attributes does the same, too. -->
<link rel="preload" href="./dbw_tester.css" as="style" onload="this.rel = 'stylesheet'">

<!-- Where error occurs. Order of the scripts doesn't seem to matter. -->
<script src="./third_party/aggressive-promise-polyfill.js"></script>

<!-- If removed, no error. -->
<script type="module" src="./empty_module.js"></script>

<!-- If removed, no error. -->
<script src="http://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>

</html>

@brendankenny
Copy link
Member

One notable thing in ToT Chromium today is top-level await (https://chromium.googlesource.com/chromium/src/+/19be7d71a9b41322599f02f0e9e0a7acbbff5943). I wonder if that could be affecting Promise stuff.

@connorjclark
Copy link
Collaborator

connorjclark commented Dec 9, 2020 •
edited
Loading

Maybe we should be tracking Chrome Dev instead of ToT (the assumption being that if this is really a bug, hopefully someone else finds and fixes before it affects us)

@brendankenny brendankenny mentioned this issue Dec 11, 2020
Merged
@paulirish
Copy link
Member Author

This error seems to also turn into a crash.

When there's a crash there's a 'Inspector.targetCrashetevent, but it's logged in verbose. After that, LH tries "Page appears to be hung, killing JavaScript..." and soon after we see aPROTOCOL_TIMEOUTw/Emulation.setScriptExecutionDisabled`. (what happened in the w/o JS removal PR: https://github.com/GoogleChrome/lighthouse/runs/1534292951 )

I bisected the crash on chromium....

python2.7 bisect_builds.py --use-local-cache -o -a mac -g 89.0.4343.0 -b 89.0.4351.0 --  --disable-features=TranslateUI --disable-extensions --disable-component-extensions-with-background-pages --disable-background-networking --disable-sync --metrics-recording-only --disable-default-apps --mute-audio --no-default-browser-check --no-first-run --disable-backgrounding-occluded-windows --disable-renderer-backgrounding --disable-background-timer-throttling --force-fieldtrials="*BackgroundTracing/default/" --remote-debugging-port=55027 --user-data-dir=/var/folders/py/rf3cszrn5kdbj_2w2jd_8wsc003dq2/T/lighthouse.XXXXXXX.qOGcKFSb --enable-logging --v=0
node lighthouse-cli/index.js http://localhost:10200/dobetterweb/dbw_tester.html -port=55027 --config-path=blahblahah

You are probably looking for a change made after 835252 (known good), but no later than 835253 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/56d85fa5f642954381267744e440faaa74814479..3904e0fe3b6a83c4aa22c960a28558612178870f

.... @brendankenny called it. 😁

@paulirish
Copy link
Member Author

Filed upstream chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1157692

@paulirish paulirish mentioned this issue Dec 11, 2020
Closed
@paulirish
Copy link
Member Author

A fix has landed upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=1157692#c4

This was referenced Dec 15, 2020
Closed
Merged
@paulirish
Copy link
Member Author

fixed by #11836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests(smoke): restore dbw_tester exception assertions GoogleChrome/lighthouse
4 participants
@paulirish @brendankenny @connorjclark @devtools-bot