-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native Node URL parsing after Node 7.2.1 errors resolved #1186
Comments
@wardpeet you mind investigating? Also happening on https://www.healthcare.gov. The url that it is upset about is |
Coincidentally I ran into this issue too a few days ago: nodejs/node#10306 |
Thanks @Janpot. Looks like a Node issue. I'm also using 7.2.1 |
@ebidel I could use whatwg instead of url for node 7 until it is fixed |
closing this one, fixed by #1187 |
I actually wanted to leave this open since we want to turn back on native node URL parsing when they fix their code. Changing the issue title to match that. |
k. The compliance issues that Jan pointed out earlier have landed in Shall we add a "Compat:" comment indicating we can retire the |
good for me! :) |
Should be obsolete by Node 8 reaching LTS |
I'm getting URL parsing errors in
audits/dobetterweb/uses-http2.js
that weren't present before #997.When running:
Think it's failing on
http://5321212.fls.doubleclick.net/activityi;src=5321212;type=unvsn_un;cat=unvsn_uv;ord=7762287885264.98?
The text was updated successfully, but these errors were encountered: