Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent usage of Chrome ToT vs Chrome Stable in smokes #14197

Closed
adamraine opened this issue Jul 6, 2022 · 3 comments
Closed

Inconsistent usage of Chrome ToT vs Chrome Stable in smokes #14197

adamraine opened this issue Jul 6, 2022 · 3 comments
Assignees
@adamraine
Labels
needs-discussion P2 test backlog disabled or needed tests

Comments

@adamraine
Copy link
Member

adamraine commented Jul 6, 2022 •
edited
Loading

Once #14153 lands the CI jobs breakdown as follows:

Stable

  • Standard CLI w/ Stable (from matrix)
  • Package test

ToT

  • Standard CLI w/ ToT (from matrix)
  • * DevTools smokes
  • Bundled
  • Windows

I like using ToT in most cases since fixes to Chrome will make it into our CI jobs sooner. It also allows us to catch issues with specific environments sooner.

* DevTools smokes will use the Chrome shipped with DevTools after #14163 lands. Will be close to ToT but not exact.
@adamraine adamraine self-assigned this Jul 6, 2022
@adamraine adamraine added needs-discussion test backlog disabled or needed tests labels Jul 6, 2022
@adamraine adamraine mentioned this issue Jul 6, 2022
Merged
@connorjclark
Copy link
Collaborator

connorjclark commented Jul 6, 2022 •
edited
Loading

FYI once #14163 lands I plan to switch devtools smokes to use the chromium that devtools frontend downloads. It should be roughly near ToT.

@brendankenny
Copy link
Member

bundled also ToT?

@adamraine
Copy link
Member Author

Ope right, I accidentally did another "Package test" lol. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamraine adamraine

Labels
needs-discussion P2 test backlog disabled or needed tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brendankenny @connorjclark @adamraine @devtools-bot