Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix CI unit tests on Node 16.x and 18 #14345

Closed
brendankenny opened this issue Sep 1, 2022 · 3 comments
Closed

fix CI unit tests on Node 16.x and 18 #14345

brendankenny opened this issue Sep 1, 2022 · 3 comments
Labels
10.0 needs-priority test backlog disabled or needed tests

Comments

@brendankenny
Copy link
Member

brendankenny commented Sep 1, 2022 •
edited by paulirish
Loading

our node version policy:

we don't support TWO maintenance releases. so when an LTS newly enters 'maintenance' we drop the older one

eg

image

Circa Oct 2022, when 16 enters maintenance we drop all support for 14.
@brendankenny brendankenny added the test backlog disabled or needed tests label Sep 1, 2022
@adamraine
Copy link
Member

The node 16 thing is currently blocked on testdouble/testdouble.js#498

@connorjclark connorjclark mentioned this issue Sep 7, 2022
Merged
This was referenced Sep 30, 2022
Merged
Merged
@adamraine
Copy link
Member

Is there anything left to do here?

@brendankenny
Copy link
Member Author

nope!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
10.0 needs-priority test backlog disabled or needed tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brendankenny @connorjclark @adamraine @devtools-bot