Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSI Report erroneously displays "Emulated Desktop" #14808

Closed
2 tasks done
patrickhulce opened this issue Feb 17, 2023 · 3 comments
Closed
2 tasks done

PSI Report erroneously displays "Emulated Desktop" #14808

patrickhulce opened this issue Feb 17, 2023 · 3 comments
Assignees

Comments

@patrickhulce
Copy link
Collaborator

patrickhulce commented Feb 17, 2023

FAQ

URL

https://blog.patrickhulce.com

What happened?

When looking at the PageSpeed report for Mobile, the info box displays "Emulated Desktop" and lists screen emulation values as undefined.

image

image

What did you expect?

I expected to see "Emulated Mobile" and the screen resolution / DPR that was used.

What have you tried?

Shouting out to my favorite Lighthouse team :)

How were you running Lighthouse?

PageSpeed Insights

Lighthouse Version

9.6.6

@connorjclark
Copy link
Collaborator

connorjclark commented Feb 17, 2023

https://googlechrome.github.io/lighthouse/viewer/?gist=9e3e31748ddad6fe33ed84990e1fe94f lhr from PSI

settings.screenEmulation is an empty object in the renderer for this LHR, which fails us here.

@connorjclark
Copy link
Collaborator

connorjclark commented Feb 17, 2023

Caused by rolling 10.0 renderer, and now we read from screenEmulation in the config, which is not represented in the lighthouse proto. Rolling back now.

const isScreenEmulationMobile = settings.channel === 'devtools' ?
settings.formFactor === 'mobile' :
settings.screenEmulation.mobile;

We could do the same thing we did previously for devtools (formFactor is present). Or we could add screenEmulation to the proto.

@connorjclark
Copy link
Collaborator

Rolled back last Friday, and #14809 will prevent this in the future.

Thanks @patrickhulce!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants