-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Way to surface non-critical errors in the report #1512
Comments
It seems this could be broken down into
|
after #1591, we probably want to add the errors in the gatherer -> audit -> report pipeline to this as well. Some things might not make sense, but e.g. if we couldn't find FCP and didn't calculate a bunch of perf metrics it should probably be called out at the top as well (this was the spirit of @addyosmani's original #812) We may want a better icon to mark them in the report as well :) |
one more thought for the CLI: as @patrickhulce notes in #1605 (comment), if something gets logged at the beginning of the LH run, it probably won't get noticed. If we figure out a nice way to pipe errors to the report (or whatever), we could also drop them in the log at the end of the CLI run so they're very visible there too. |
Starting list of things to warn on:
|
addressed by #3692 |
From #1492 (review)
For individual gatherers/audit errors, we surface
debugString
.Right now, fatal errors stop the extension from running and we show a "report error" button. However, for non-fatal errors that happen outside of the gatherer -> audit -> report pipeline, we don't have a way to surface those errors to extension users.
Without analytics, we don't know about non-fatal errors. The HTML report could have a section where users see overall LH non-fatal errors and file bugs against us.
The text was updated successfully, but these errors were encountered: