Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest contains start_url false positive #1609

Closed
paulirish opened this issue Feb 2, 2017 · 4 comments
Closed

Manifest contains start_url false positive #1609

paulirish opened this issue Feb 2, 2017 · 4 comments

Comments

@paulirish
Copy link
Member

Test case: https://meduza.io/

Their manifest looks like this:

{
  "display": "standalone",
  "gcm_sender_id": "999059432363",
  "gcm_user_visible_only": true
}

But somehow we say it has a start_url

image

@brendankenny
Copy link
Member

Technically this is correct...if there's any error in the start_url value (or if it's missing) the document URL is used as the start_url.

We do have a debugString warning about the problem, though. Should we output that even though it passes?

We could also set the displayValue, maybe, so you'd have a chance to notice that it might be set to the document URL when you meant it to be something else.

@paulirish
Copy link
Member Author

well then "manifest contains a start_url" text is incorrect.

and its more like.. "start_url location resolved"

@brendankenny
Copy link
Member

yeah, good point

@brendankenny
Copy link
Member

start_url is actually loaded now, not just checked for in the manifest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants