Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit suggestion: track failed HTTP requests #3128

Closed
alekseykulikov opened this issue Aug 25, 2017 · 4 comments
Closed

audit suggestion: track failed HTTP requests #3128

alekseykulikov opened this issue Aug 25, 2017 · 4 comments

Comments

@alekseykulikov
Copy link
Contributor

During page execution: ajax requests may fail, or images/js/css didn't exist and returned 404. That may be a solid recommendation to fix.
It's similar to the tracking of javascript errors #3109, 0 failed HTTP request is a valid expectation.

@patrickhulce
Copy link
Collaborator

HTTP failures result in console errors, so #2836 should actually address this as well.

@alekseykulikov
Copy link
Contributor Author

@patrickhulce good point! I may try to extract changes from #2836 and provide new PR to add only this audit.

@patrickhulce
Copy link
Collaborator

fixed by #2836

@paulirish
Copy link
Member

and provide new PR to add only this audit.

@alekseykulikov you could do that, though we may then have some interesting overlap between the two. It's a little awkward so we favor keeping the 2836 audit all-together. does that work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants