Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text compression with HTTP2 tip #3548

Closed
ghost opened this issue Oct 13, 2017 · 4 comments
Closed

Text compression with HTTP2 tip #3548

ghost opened this issue Oct 13, 2017 · 4 comments

Comments

@ghost
Copy link

ghost commented Oct 13, 2017

I'm wondering if hint:

  • Performance > Opportunities > Enable text compression

is relevant while using HTTP2?
Or perhaps I misunderstand this tip? Then maybe more precise message could be shown?

image

@vinamratasingal-zz
Copy link

vinamratasingal-zz commented Oct 13, 2017

Hi! Thanks for filing an issue about this.

I think what you're asking for is if HTTP/2 automatically does text compression, to which the answer is no. This audit is telling you to compress your responses. HTTP/2 does not automatically compress your responses, so you still need to implement that optimization. For what it's worth, the total gain from this optimization is pretty small (only shaves off 70 ms in your case), so it's totally fine to focus on other optimizations! If you have any feedback around how we can make that less confusing, let us know.

@ghost
Copy link
Author

ghost commented Oct 13, 2017

According to this (They're talking about this).

When HTTPS2 is detected, message should be focused more on preload?

@patrickhulce
Copy link
Collaborator

patrickhulce commented Oct 13, 2017

@xliiv thanks for sharing the video! The speaker though is claiming that the benefits of CSS and JS minification are negligible when you're already using GZIP compression (within 1% file size), not that there is not a benefit to using text compression when serving assets over H2. Your recommendation on preload is a great point and in fact we're already on the case! (see #3450)

Lighthouse does not currently audit for minification, but when we do rest assured that in cases where the difference really is just 1% we would not surface that as a priority :)

UPDATE: here's a quick guide on the difference between minification and compression https://css-tricks.com/the-difference-between-minification-and-gzipping/

@ghost
Copy link
Author

ghost commented Oct 14, 2017

Thanks for clarification. I think we could close this issue then. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants