-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit - aspect ratio is always throwing an error #3551
Comments
Thanks for the report! That's definitely a bug...zero results is being turned into a 0 score, which is why it's failing but no image information is being displayed. Sorry to have left you with such a head scratcher. |
Fixed on master. We're planning on a release next week, so should be on npm then. |
Sorry but the original issue report indicated two problems. That it triggered at all with two supposedly correct images and then still reporting with no images. We get the same auditing error now too, but since the audit does not contain any info as to which image failed it is extremely hard to track down whether its a false positive. Which leaves us having to write a script to double check the site. Is the audit intended to contain an indicator as to where it failed anytime soon ? |
Hi ! |
lighthouse 2.5.1 audit tests.
the Does not uses Images with appropriate aspect ratio is always failing. This test does not tell you which file is failing the test. We then took all all of the images from the page and we still get this error. We had to turn off our lighthouse test for the time because of this. Here is an example page
https://jcdalton2201.github.io/progressive-app-test/ we have one img and its 80 X 80 the nat is 150 X 150.
The text was updated successfully, but these errors were encountered: