Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign displayValue/warnings #5153

Closed
patrickhulce opened this issue May 7, 2018 · 0 comments · Fixed by #5270
Closed

Redesign displayValue/warnings #5153

patrickhulce opened this issue May 7, 2018 · 0 comments · Fixed by #5270

Comments

@patrickhulce
Copy link
Collaborator

patrickhulce commented May 7, 2018

@brendankenny expressed some concerns over our displayValue/warnings display methods over in #5132 (review)

two things

1. visually associating of displayValue + audit title

A few major things for how we handle these different outputs:

It's great to start using displayValue for things that are display values, but it does expose a weakness with how we display them. It's definitely harder to scan across to the value for the audit vs just having it right below

old:
screen shot 2018-05-07 at 12 31 10

new:
screen shot 2018-05-07 at 12 31 18
(and it's even wider across when not shrunk by github)

2. warnings at the top of the report

Separating the warnings from the audits seems like a regression from the status quo in most of the warnings cases added here. Having a list of images we can't reencode at the top of the report or (in the case of sample_v2.json) a warning that some target=_blank anchors may be outgoing but we can't tell, seems like noise at the top of the report and is lost as valuable context at the individual audit level (where you probably want to be warned that the audit may have been unable to comprehensively run its test).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants