Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace details tag in html report viewer to support jumping to a specific audit by id anchor #5640

Closed
nmchau opened this issue Jul 9, 2018 · 3 comments

Comments

@nmchau
Copy link

nmchau commented Jul 9, 2018

Feature request

Summary

In html report viewer, each audit component has id element but many of them are inside the details tags. So, it's impossible to jump to a specific audit component by its id without expanding the parent details tags.
For example, report.html#mobile-friendly link can't allow us to jump to 'mobile friendly' audit because this audit stays inside a details tag.

What is the motivation or use case for changing this?
Some people are just interested in some specific audits among many audits supported by Lighthouse.

How is this beneficial to Lighthouse?
Links which allow jumping directly to different audits in report viewer can be bookmarked or shared easily.

@patrickhulce
Copy link
Collaborator

Neat idea! We might want to consider alternatives to support this, perhaps instead we could auto-open the parent with JS on navigation or something.

@paulirish
Copy link
Member

solution: if targeted audit is within a collapsed details (or multiple of them), we open those with JS. maybe we also highlight background via :target CSS.

@brendankenny
Copy link
Member

let's track in #6668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants