New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include lab data summary sentence in prepareLabData #5882

Closed

paulirish opened this issue Aug 21, 2018 · 1 comment · Fixed by #5961

Assignees

Labels

Member

paulirish commented Aug 21, 2018

As requested.

paulirish assigned paulirish and brendankenny and unassigned paulirish

Member Author

paulirish commented Aug 22, 2018

@brendankenny if you can get this sentence added and the latest strings rolled into g3, that'd be rad.

Lighthouse analysis of the current page on emulated 3G. Values are estimated and may vary.

we already have the 2nd part of it in TC if you just want to concatenate the sentences. (that is valid, they say)

paulirish added needs-priority report P1 and removed needs-priority labels

brendankenny mentioned this issue

report(psi): add lab data summary sentence #5961

Merged

paulirish closed this as completed in #5961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment