Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race trace parsing and chunk fetching #5939

Closed
paulirish opened this issue Aug 30, 2018 · 0 comments · Fixed by #6056
Closed

Race trace parsing and chunk fetching #5939

paulirish opened this issue Aug 30, 2018 · 0 comments · Fixed by #6056
Assignees
@brendankenny
Labels
OYB P1

Comments

@paulirish
Copy link
Member

On LR (and extension to some degree), we've been seeing trace retrieval taking a lot of time.

Here's a timing breakdown when getTrace takes 14sec:

image

Brendan's idea is to race our streaming JS parser and fetching the next chunk of the trace.

Adds some complexity to the async handling, but the perf win would be ~2100ms on this recording.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brendankenny brendankenny

Labels
OYB P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core(driver): deliver trace as events rather than a stream GoogleChrome/lighthouse
2 participants
@paulirish @brendankenny