Missing Fields in proto!

[exterkamp]

What is the current behavior?

Lighthouse_result.proto has some missing fields! Doh!

• config_settings.audit_mode
• Timing

[patrickhulce]

Maybe step one before/while adding these, is adding a round trip assertion test? :)

[exterkamp]

The reason these were missed was because the sample json cleans these two fields out for testing! So I totally missed them!

I support round-tripping the smokehouse JSONs or pulling some real world ones and round tripping them. The diffing gets complicated though. That has been the problem. @paulirish

[patrickhulce]

Oh I didn't realize we were just going to reuse the existing diff infra for it :)

Since that diffing was made to go between runs where timing/date/etc might end up changing and this one is about detecting any data loss on a roundtrip would it might make sense to use a stricter diff for the protobuf?

[exterkamp]

Yes, we could do a much stricter diff for protobuf. I'm doing that kind of strict diffing for LR, but it should be done for LH too. The current sample roundtrip was always a first step.

[patrickhulce]

Oh cool sorry I didn't realize we're already doing it for LR!