Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ligthouse checks for an icon in the manifest but does not try to load it #789

Closed
juliantoledo opened this issue Oct 17, 2016 · 6 comments · Fixed by #10168
Closed

Ligthouse checks for an icon in the manifest but does not try to load it #789

juliantoledo opened this issue Oct 17, 2016 · 6 comments · Fixed by #10168
Labels

Comments

@juliantoledo
Copy link

While collection few PWA examples I have found that many manifest have icon URLs but they are actually broken, 404 or errors in the relative path.

I think that "Manifest contains icons at least 144px" should not be true if the URL is broken, or at least have another way to point it out in the report.

@brendankenny
Copy link
Member

brendankenny commented Oct 17, 2016

The DevTools fetches the icons for display in the Application panel. It doesn't appear to go through the host page, though, as the icon fetch doesn't show up in the network panel like the fetch of the manifest itself does.

@paulirish any idea where the Application panel gets those? Is it something Lighthouse can piggyback on?

@paulirish
Copy link
Member

Application panel just reads the icon URLs and does a new URL(iconURL, manifestURL) and image.src's it:

image

but yeah we should validate these icons don't 404.

we probably want to request from inside the host page.. (however devtools doesn't use any fancy auth)

@bitterjug
Copy link

I ran into this today. Lighthouse says "User can be prompted to Install the Web App" but no A2HS appears on my phone and I ended up inspecting it via remote debug tools and triggering the A2HS to see "The site cannot be installed: icon downloaded from the manifest was empty or corrupted" errors.

@docluv
Copy link

docluv commented Jun 21, 2018

I am getting a similar error as bitterjug.

Error while trying to use the following icon from the Manifest: http://localhost:57661/meta/android/android-launchericon-144-144.png (Download error or resource isn't a valid image)
11:00:24.067 localhost/:1 Site cannot be installed: icon downloaded from the manifest was empty or corrupted

The image loads fine in any image editor and browser. The URL returns the image, etc. So I am wondering what triggers this error and how to correct it.

@filt3rek
Copy link

Hej guys !

I still have this error when launching an audit with devtools : (Download error or resource isn't a valid image) when trying to load the android-144x144 image
Is it a bug or do I miss something please ?

@connorjclark
Copy link
Collaborator

DT release cycle is long. Will be months before it is fixed there. fix is in master, we are about to do a 6.0 release to npm, but DT is longer b/c of Chromium release cycle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants