-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ligthouse checks for an icon in the manifest but does not try to load it #789
Comments
The DevTools fetches the icons for display in the Application panel. It doesn't appear to go through the host page, though, as the icon fetch doesn't show up in the network panel like the fetch of the manifest itself does. @paulirish any idea where the Application panel gets those? Is it something Lighthouse can piggyback on? |
I ran into this today. Lighthouse says "User can be prompted to Install the Web App" but no A2HS appears on my phone and I ended up inspecting it via remote debug tools and triggering the A2HS to see "The site cannot be installed: icon downloaded from the manifest was empty or corrupted" errors. |
I am getting a similar error as bitterjug. Error while trying to use the following icon from the Manifest: http://localhost:57661/meta/android/android-launchericon-144-144.png (Download error or resource isn't a valid image) The image loads fine in any image editor and browser. The URL returns the image, etc. So I am wondering what triggers this error and how to correct it. |
Hej guys ! I still have this error when launching an audit with devtools : (Download error or resource isn't a valid image) when trying to load the android-144x144 image |
DT release cycle is long. Will be months before it is fixed there. fix is in master, we are about to do a 6.0 release to npm, but DT is longer b/c of Chromium release cycle |
While collection few PWA examples I have found that many manifest have icon URLs but they are actually broken, 404 or errors in the relative path.
I think that "Manifest contains icons at least 144px" should not be true if the URL is broken, or at least have another way to point it out in the report.
The text was updated successfully, but these errors were encountered: