-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
artifact: fetch manifest based on triggered network request #83
Comments
Once https://codereview.chromium.org/1835063002/ lands, enable-add-to-shelf will not be required. In the meantime, we can force the flag for node, but not for extension. We might want to consider requiring Canary for using the extension. (Otherwise we'll be waiting for fixes like this to hit stable) |
Okay another bug we'll get resolved... on https://operasoftware.github.io/pwa-list/ things fail because it's in a subfolder and our browser fetching assumes manifest is at domain root. There's a fix for it but I think I'd rather rely on the real thing. |
@brendankenny when do you think you'll have a PR up for this? |
Aiming for tomorrow |
@brendankenny sounds good thank ya |
so, one additional development here seems to be that in Canary, if you have |
try https://jakearchibald.github.io/svgomg/ with your PR. i get invalid JSON errors with the extension currently. |
Calling
requestAppBanner
will fetch the manifest, which we can pick up in the network requests record.This avoids the DOM dance and make sure we're testing the same manifest that Chrome does.
for now you need
--enable-add-to-shelf
for this to workThe text was updated successfully, but these errors were encountered: