Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifact: fetch manifest based on triggered network request #83

Closed
brendankenny opened this issue Mar 25, 2016 · 8 comments
Closed

artifact: fetch manifest based on triggered network request #83

brendankenny opened this issue Mar 25, 2016 · 8 comments
Assignees

Comments

@brendankenny
Copy link
Member

Calling requestAppBanner will fetch the manifest, which we can pick up in the network requests record.

This avoids the DOM dance and make sure we're testing the same manifest that Chrome does.

for now you need --enable-add-to-shelf for this to work

@brendankenny brendankenny changed the title fetch manifest based on triggered network request artifact: fetch manifest based on triggered network request Mar 25, 2016
@paulirish
Copy link
Member

Once https://codereview.chromium.org/1835063002/ lands, enable-add-to-shelf will not be required.
Star https://bugs.chromium.org/p/chromium/issues/detail?id=540491 for updates.

In the meantime, we can force the flag for node, but not for extension.

We might want to consider requiring Canary for using the extension. (Otherwise we'll be waiting for fixes like this to hit stable)

@paulirish
Copy link
Member

This will also mean we can clean up the depedency on request and the localized requires here

image

@paulirish
Copy link
Member

Okay another bug we'll get resolved... on https://operasoftware.github.io/pwa-list/ things fail because it's in a subfolder and our browser fetching assumes manifest is at domain root.

There's a fix for it but I think I'd rather rely on the real thing.

image

@paulirish
Copy link
Member

@brendankenny when do you think you'll have a PR up for this?

@brendankenny
Copy link
Member Author

Aiming for tomorrow

@paulirish
Copy link
Member

@brendankenny sounds good thank ya

@brendankenny
Copy link
Member Author

so, one additional development here seems to be that in Canary, if you have Add to shelf enabled in about:flags, Chrome now fetches the manifest on navigation. Is this coming sooner than we expected?

@paulirish
Copy link
Member

try https://jakearchibald.github.io/svgomg/ with your PR. i get invalid JSON errors with the extension currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants