diff --git a/cli/test/smokehouse/test-definitions/a11y.js b/cli/test/smokehouse/test-definitions/a11y.js index 044f7a1ae85e..ac49d4d1e23d 100644 --- a/cli/test/smokehouse/test-definitions/a11y.js +++ b/cli/test/smokehouse/test-definitions/a11y.js @@ -331,12 +331,8 @@ const expectations = { }, }, 'bypass': { - score: 1, - details: { - type: 'table', - headings: [], - items: [], - }, + score: null, + scoreDisplayMode: 'notApplicable', }, 'color-contrast': { score: 0, diff --git a/core/audits/accessibility/bypass.js b/core/audits/accessibility/bypass.js index 6135657cb2c6..25773516ba90 100644 --- a/core/audits/accessibility/bypass.js +++ b/core/audits/accessibility/bypass.js @@ -36,6 +36,7 @@ class Bypass extends AxeAudit { title: str_(UIStrings.title), failureTitle: str_(UIStrings.failureTitle), description: str_(UIStrings.description), + scoreDisplayMode: AxeAudit.SCORING_MODES.INFORMATIVE, requiredArtifacts: ['Accessibility'], }; } diff --git a/core/audits/accessibility/th-has-data-cells.js b/core/audits/accessibility/th-has-data-cells.js index 4eae5ceb2fc4..3c4f5e5f1138 100644 --- a/core/audits/accessibility/th-has-data-cells.js +++ b/core/audits/accessibility/th-has-data-cells.js @@ -38,6 +38,7 @@ class THHasDataCells extends AxeAudit { title: str_(UIStrings.title), failureTitle: str_(UIStrings.failureTitle), description: str_(UIStrings.description), + scoreDisplayMode: AxeAudit.SCORING_MODES.INFORMATIVE, requiredArtifacts: ['Accessibility'], }; } diff --git a/core/audits/accessibility/video-caption.js b/core/audits/accessibility/video-caption.js index a974ddbaaf79..93c6bb4dc079 100644 --- a/core/audits/accessibility/video-caption.js +++ b/core/audits/accessibility/video-caption.js @@ -36,6 +36,7 @@ class VideoCaption extends AxeAudit { title: str_(UIStrings.title), failureTitle: str_(UIStrings.failureTitle), description: str_(UIStrings.description), + scoreDisplayMode: AxeAudit.SCORING_MODES.INFORMATIVE, requiredArtifacts: ['Accessibility'], }; } diff --git a/core/test/fixtures/fraggle-rock/reports/sample-flow-result.json b/core/test/fixtures/fraggle-rock/reports/sample-flow-result.json index 9f5091307fd0..8edb79c9a603 100644 --- a/core/test/fixtures/fraggle-rock/reports/sample-flow-result.json +++ b/core/test/fixtures/fraggle-rock/reports/sample-flow-result.json @@ -2642,13 +2642,8 @@ "id": "bypass", "title": "The page contains a heading, skip link, or landmark region", "description": "Adding ways to bypass repetitive content lets keyboard users navigate the page more efficiently. [Learn more about bypass blocks](https://dequeuniversity.com/rules/axe/4.4/bypass).", - "score": 1, - "scoreDisplayMode": "binary", - "details": { - "type": "table", - "headings": [], - "items": [] - } + "score": null, + "scoreDisplayMode": "notApplicable" }, "color-contrast": { "id": "color-contrast", @@ -4146,7 +4141,7 @@ }, { "id": "bypass", - "weight": 3, + "weight": 0, "group": "a11y-navigation" }, { @@ -11282,13 +11277,8 @@ "id": "bypass", "title": "The page contains a heading, skip link, or landmark region", "description": "Adding ways to bypass repetitive content lets keyboard users navigate the page more efficiently. [Learn more about bypass blocks](https://dequeuniversity.com/rules/axe/4.4/bypass).", - "score": 1, - "scoreDisplayMode": "binary", - "details": { - "type": "table", - "headings": [], - "items": [] - } + "score": null, + "scoreDisplayMode": "notApplicable" }, "color-contrast": { "id": "color-contrast", @@ -12504,7 +12494,7 @@ }, { "id": "bypass", - "weight": 3, + "weight": 0, "group": "a11y-navigation" }, { @@ -16615,13 +16605,8 @@ "id": "bypass", "title": "The page contains a heading, skip link, or landmark region", "description": "Adding ways to bypass repetitive content lets keyboard users navigate the page more efficiently. [Learn more about bypass blocks](https://dequeuniversity.com/rules/axe/4.4/bypass).", - "score": 1, - "scoreDisplayMode": "binary", - "details": { - "type": "table", - "headings": [], - "items": [] - } + "score": null, + "scoreDisplayMode": "notApplicable" }, "color-contrast": { "id": "color-contrast", @@ -18288,7 +18273,7 @@ }, { "id": "bypass", - "weight": 3, + "weight": 0, "group": "a11y-navigation" }, { diff --git a/core/test/results/sample_v2.json b/core/test/results/sample_v2.json index da9c72fb8721..c7077e02f7d0 100644 --- a/core/test/results/sample_v2.json +++ b/core/test/results/sample_v2.json @@ -3552,13 +3552,8 @@ "id": "bypass", "title": "The page contains a heading, skip link, or landmark region", "description": "Adding ways to bypass repetitive content lets keyboard users navigate the page more efficiently. [Learn more about bypass blocks](https://dequeuniversity.com/rules/axe/4.4/bypass).", - "score": 1, - "scoreDisplayMode": "binary", - "details": { - "type": "table", - "headings": [], - "items": [] - } + "score": null, + "scoreDisplayMode": "notApplicable" }, "color-contrast": { "id": "color-contrast", @@ -6392,7 +6387,7 @@ }, { "id": "bypass", - "weight": 3, + "weight": 0, "group": "a11y-navigation" }, { @@ -6562,7 +6557,7 @@ } ], "id": "accessibility", - "score": 0.78 + "score": 0.77 }, "best-practices": { "title": "Best Practices", diff --git a/report/test/generator/report-generator-test.js b/report/test/generator/report-generator-test.js index 1b1ba9f21877..d914330793b0 100644 --- a/report/test/generator/report-generator-test.js +++ b/report/test/generator/report-generator-test.js @@ -95,7 +95,7 @@ describe('ReportGenerator', () => { category,score \\"performance\\",\\"0.26\\" -\\"accessibility\\",\\"0.78\\" +\\"accessibility\\",\\"0.77\\" \\"best-practices\\",\\"0.27\\" \\"seo\\",\\"0.67\\" \\"pwa\\",\\"0.33\\" diff --git a/report/test/renderer/category-renderer-test.js b/report/test/renderer/category-renderer-test.js index cd888941d8c4..978fbff1880b 100644 --- a/report/test/renderer/category-renderer-test.js +++ b/report/test/renderer/category-renderer-test.js @@ -296,7 +296,7 @@ describe('CategoryRenderer', () => { ); const gauge = categoryDOM.querySelector('.lh-fraction__content'); - assert.equal(gauge.textContent.trim(), '13/18', 'fraction is included'); + assert.equal(gauge.textContent.trim(), '12/17', 'fraction is included'); const score = categoryDOM.querySelector('.lh-category-header'); const title = score.querySelector('.lh-fraction__label');