From 6e551da7fcc8a081cecc2c5dae3a682a6caabeff Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Wed, 14 Jun 2023 11:31:58 -0700 Subject: [PATCH 1/2] core(stacks): add wix --- core/lib/stack-packs.js | 4 ++++ core/test/lib/stack-packs-test.js | 11 +++++++++++ package.json | 2 +- shared/localization/locales/en-US.json | 15 +++++++++++++++ shared/localization/locales/en-XL.json | 15 +++++++++++++++ yarn.lock | 8 ++++---- 6 files changed, 50 insertions(+), 5 deletions(-) diff --git a/core/lib/stack-packs.js b/core/lib/stack-packs.js index 77b90a560550..1b7ec3534fd5 100644 --- a/core/lib/stack-packs.js +++ b/core/lib/stack-packs.js @@ -67,6 +67,10 @@ const stackPacksToInclude = [ packId: 'react', requiredStacks: ['js:react'], }, + { + packId: 'wix', + requiredStacks: ['js:wix'], + }, ]; /** diff --git a/core/test/lib/stack-packs-test.js b/core/test/lib/stack-packs-test.js index 4bba8d5663bf..d157936ce606 100644 --- a/core/test/lib/stack-packs-test.js +++ b/core/test/lib/stack-packs-test.js @@ -60,6 +60,7 @@ Array [ "nuxt", "octobercms", "react", + "wix", "wordpress", "wp-rocket", ] @@ -242,6 +243,16 @@ Array [ "dom-size", ], }, + Object { + "id": "wix", + "keys": Array [ + "modern-image-formats", + "render-blocking-resources", + "efficient-animated-content", + "unused-javascript", + "server-response-time", + ], + }, Object { "id": "wordpress", "keys": Array [ diff --git a/package.json b/package.json index f5689ae72d0e..0ab27f4f94e5 100644 --- a/package.json +++ b/package.json @@ -198,7 +198,7 @@ "jpeg-js": "^0.4.4", "js-library-detector": "^6.6.0", "lighthouse-logger": "^1.4.1", - "lighthouse-stack-packs": "1.10.0", + "lighthouse-stack-packs": "1.11.0", "lodash": "^4.17.21", "lookup-closest-locale": "6.2.0", "metaviewport-parser": "0.3.0", diff --git a/shared/localization/locales/en-US.json b/shared/localization/locales/en-US.json index d70cdc49457b..56dd94fc569b 100644 --- a/shared/localization/locales/en-US.json +++ b/shared/localization/locales/en-US.json @@ -3062,6 +3062,21 @@ "node_modules/lighthouse-stack-packs/packs/react.js | user-timings": { "message": "Use the React DevTools Profiler, which makes use of the Profiler API, to measure the rendering performance of your components. [Learn more.](https://reactjs.org/blog/2018/09/10/introducing-the-react-profiler.html)" }, + "node_modules/lighthouse-stack-packs/packs/wix.js | efficient-animated-content": { + "message": "Place videos inside `VideoBoxes`, customize them using `Video Masks` or add `Transparent Videos`. [Learn more](https://support.wix.com/en/article/wix-video-about-wix-video)." + }, + "node_modules/lighthouse-stack-packs/packs/wix.js | modern-image-formats": { + "message": "Upload images using `Wix Media Manager` to ensure they are automatically served as WebP. Find [more ways to optimize](https://support.wix.com/en/article/site-performance-optimizing-your-media) your site's media." + }, + "node_modules/lighthouse-stack-packs/packs/wix.js | render-blocking-resources": { + "message": "When [adding third-party code](https://support.wix.com/en/article/site-performance-using-third-party-code-on-your-site) in the `Custom Code` tab of your site's dashboard, make sure it's deferred or loaded at the end of the code body. Where possible, use Wix’s [integrations](https://support.wix.com/en/article/about-marketing-integrations) to embed marketing tools on your site. " + }, + "node_modules/lighthouse-stack-packs/packs/wix.js | server-response-time": { + "message": "Wix utilizes CDNs and caching to serve responses as fast as possible for most visitors. Consider [manually enabling caching](https://support.wix.com/en/article/site-performance-caching-pages-to-optimize-loading-speed) for your site, especially if using `Velo`." + }, + "node_modules/lighthouse-stack-packs/packs/wix.js | unused-javascript": { + "message": "Review any third-party code you've added to your site in the `Custom Code` tab of your site's dashboard and only keep the services that are necessary to your site. [Find out more](https://support.wix.com/en/article/site-performance-removing-unused-javascript)." + }, "node_modules/lighthouse-stack-packs/packs/wordpress.js | efficient-animated-content": { "message": "Consider uploading your GIF to a service which will make it available to embed as an HTML5 video." }, diff --git a/shared/localization/locales/en-XL.json b/shared/localization/locales/en-XL.json index c979dd35c556..6a2016b60968 100644 --- a/shared/localization/locales/en-XL.json +++ b/shared/localization/locales/en-XL.json @@ -3062,6 +3062,21 @@ "node_modules/lighthouse-stack-packs/packs/react.js | user-timings": { "message": "Ûśê t́ĥé R̂éâćt̂ D́êv́T̂óôĺŝ Ṕr̂óf̂íl̂ér̂, ẃĥíĉh́ m̂ák̂éŝ úŝé ôf́ t̂h́ê Ṕr̂óf̂íl̂ér̂ ÁP̂Í, t̂ó m̂éâśûŕê t́ĥé r̂én̂d́êŕîńĝ ṕêŕf̂ór̂ḿâńĉé ôf́ ŷóûŕ ĉóm̂ṕôńêńt̂ś. [L̂éâŕn̂ ḿôŕê.](https://reactjs.org/blog/2018/09/10/introducing-the-react-profiler.html)" }, + "node_modules/lighthouse-stack-packs/packs/wix.js | efficient-animated-content": { + "message": "P̂ĺâćê v́îd́êóŝ ín̂śîd́ê `VideoBoxes`, ćûśt̂óm̂íẑé t̂h́êḿ ûśîńĝ `Video Masks` ór̂ ád̂d́ `Transparent Videos`. [L̂éâŕn̂ ḿôŕê](https://support.wix.com/en/article/wix-video-about-wix-video)." + }, + "node_modules/lighthouse-stack-packs/packs/wix.js | modern-image-formats": { + "message": "Ûṕl̂óâd́ îḿâǵêś ûśîńĝ `Wix Media Manager` t́ô én̂śûŕê t́ĥéŷ ár̂é âút̂óm̂át̂íĉál̂ĺŷ śêŕv̂éd̂ áŝ Ẃêb́P̂. F́îńd̂ [ḿôŕê ẃâýŝ t́ô óp̂t́îḿîźê](https://support.wix.com/en/article/site-performance-optimizing-your-media) ýôúr̂ śît́ê'ś m̂éd̂íâ." + }, + "node_modules/lighthouse-stack-packs/packs/wix.js | render-blocking-resources": { + "message": "Ŵh́êń [âd́d̂ín̂ǵ t̂h́îŕd̂-ṕâŕt̂ý ĉód̂é](https://support.wix.com/en/article/site-performance-using-third-party-code-on-your-site) îń t̂h́ê `Custom Code` t́âb́ ôf́ ŷóûŕ ŝít̂é'ŝ d́âśĥb́ôár̂d́, m̂ák̂é ŝúr̂é ît́'ŝ d́êf́êŕr̂éd̂ ór̂ ĺôád̂éd̂ át̂ t́ĥé êńd̂ óf̂ t́ĥé ĉód̂é b̂ód̂ý. Ŵh́êŕê ṕôśŝíb̂ĺê, úŝé Ŵíx̂’ś [îńt̂éĝŕât́îón̂ś](https://support.wix.com/en/article/about-marketing-integrations) t̂ó êḿb̂éd̂ ḿâŕk̂ét̂ín̂ǵ t̂óôĺŝ ón̂ ýôúr̂ śît́ê. " + }, + "node_modules/lighthouse-stack-packs/packs/wix.js | server-response-time": { + "message": "Ŵíx̂ út̂íl̂íẑéŝ ĆD̂Ńŝ án̂d́ ĉáĉh́îńĝ t́ô śêŕv̂é r̂éŝṕôńŝéŝ áŝ f́âśt̂ áŝ ṕôśŝíb̂ĺê f́ôŕ m̂óŝt́ v̂íŝít̂ór̂ś. Ĉón̂śîd́êŕ [m̂án̂úâĺl̂ý êńâb́l̂ín̂ǵ ĉáĉh́îńĝ](https://support.wix.com/en/article/site-performance-caching-pages-to-optimize-loading-speed) f́ôŕ ŷóûŕ ŝít̂é, êśp̂éĉíâĺl̂ý îf́ ûśîńĝ `Velo`." + }, + "node_modules/lighthouse-stack-packs/packs/wix.js | unused-javascript": { + "message": "R̂év̂íêẃ âńŷ t́ĥír̂d́-p̂ár̂t́ŷ ćôd́ê ýôú'v̂é âd́d̂éd̂ t́ô ýôúr̂ śît́ê ín̂ t́ĥé `Custom Code` t̂áb̂ óf̂ ýôúr̂ śît́ê'ś d̂áŝh́b̂óâŕd̂ án̂d́ ôńl̂ý k̂éêṕ t̂h́ê śêŕv̂íĉéŝ t́ĥát̂ ár̂é n̂éĉéŝśâŕŷ t́ô ýôúr̂ śît́ê. [F́îńd̂ óût́ m̂ór̂é](https://support.wix.com/en/article/site-performance-removing-unused-javascript)." + }, "node_modules/lighthouse-stack-packs/packs/wordpress.js | efficient-animated-content": { "message": "Ĉón̂śîd́êŕ ûṕl̂óâd́îńĝ ýôúr̂ ǴÎF́ t̂ó â śêŕv̂íĉé ŵh́îćĥ ẃîĺl̂ ḿâḱê ít̂ áv̂áîĺâb́l̂é t̂ó êḿb̂éd̂ áŝ án̂ H́T̂ḾL̂5 v́îd́êó." }, diff --git a/yarn.lock b/yarn.lock index c6b9c60fccf2..3e3497f144b1 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5210,10 +5210,10 @@ lighthouse-plugin-soft-navigation@^1.0.1: resolved "https://registry.yarnpkg.com/lighthouse-plugin-soft-navigation/-/lighthouse-plugin-soft-navigation-1.0.1.tgz#82fb2008991458d753a819dd3e1f076d55eb2bfb" integrity sha512-lvwiC9Bp/kzx7WTsPw/tjv1MkeRnvX2rKNTHDBSOOPYLsvaPrnaCk+6n+1sfinwLM6LAAWp5B9mTdi+G/31iDQ== -lighthouse-stack-packs@1.10.0: - version "1.10.0" - resolved "https://registry.yarnpkg.com/lighthouse-stack-packs/-/lighthouse-stack-packs-1.10.0.tgz#1036db27deb27506012e767202489689524a26e9" - integrity sha512-5nvJS+IkZUbnDpIeJLi1xdnCfftBFMkxXfA5HHlEC1EQFQ2a8YPos6vl11oERHuIlDFEnVkaOeNaSIrL2K/9Gg== +lighthouse-stack-packs@1.11.0: + version "1.11.0" + resolved "https://registry.yarnpkg.com/lighthouse-stack-packs/-/lighthouse-stack-packs-1.11.0.tgz#9b17b24651b60242581abf2086ea34ff1c869f58" + integrity sha512-sRr0z1S/I26VffRLq9KJsKtLk856YrJlNGmcJmbLX8dFn3MuzVPUbstuChEhqnSxZb8TZmVfthuXuwhG9vRoSw== lines-and-columns@^1.1.6: version "1.2.4" From b1bcbe4ac0617b383ab418103bbf68257a0b7a75 Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Wed, 14 Jun 2023 11:47:12 -0700 Subject: [PATCH 2/2] order --- core/lib/stack-packs.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/core/lib/stack-packs.js b/core/lib/stack-packs.js index 1b7ec3534fd5..ac00fc4f314f 100644 --- a/core/lib/stack-packs.js +++ b/core/lib/stack-packs.js @@ -23,6 +23,10 @@ const stackPacksToInclude = [ packId: 'wordpress', requiredStacks: ['js:wordpress'], }, + { + packId: 'wix', + requiredStacks: ['js:wix'], + }, { packId: 'wp-rocket', requiredStacks: ['js:wp-rocket'], @@ -67,10 +71,6 @@ const stackPacksToInclude = [ packId: 'react', requiredStacks: ['js:react'], }, - { - packId: 'wix', - requiredStacks: ['js:wix'], - }, ]; /**