From 8cda992f226a68cab271b56ebc1d76923d27fd5a Mon Sep 17 00:00:00 2001 From: Steve Persch Date: Wed, 11 Oct 2017 12:25:26 -0500 Subject: [PATCH 1/3] Adding weight to categories --- lighthouse-core/config/default.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lighthouse-core/config/default.js b/lighthouse-core/config/default.js index 5a6e994d0334..c5221b8cfa2e 100644 --- a/lighthouse-core/config/default.js +++ b/lighthouse-core/config/default.js @@ -222,6 +222,7 @@ module.exports = { }, 'performance': { name: 'Performance', + weight: 1, description: 'These encapsulate your app\'s current performance and opportunities to improve it.', audits: [ {id: 'first-meaningful-paint', weight: 5, group: 'perf-metric'}, @@ -247,6 +248,7 @@ module.exports = { }, 'accessibility': { name: 'Accessibility', + weight: 1, description: 'These checks highlight opportunities to [improve the accessibility of your app](https://developers.google.com/web/fundamentals/accessibility).', audits: [ {id: 'accesskeys', weight: 1, group: 'a11y-correct-attributes'}, @@ -288,6 +290,7 @@ module.exports = { }, 'best-practices': { name: 'Best Practices', + weight: 1, description: 'We\'ve compiled some recommendations for modernizing your web app and avoiding performance pitfalls.', audits: [ {id: 'appcache-manifest', weight: 1}, From 09cc4ae7500ff10e0f04601d2a92bce698ad9011 Mon Sep 17 00:00:00 2001 From: Steve Persch Date: Wed, 11 Oct 2017 17:04:14 -0500 Subject: [PATCH 2/3] Revert "Adding weight to categories" This reverts commit 8cda992f226a68cab271b56ebc1d76923d27fd5a. --- lighthouse-core/config/default.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/lighthouse-core/config/default.js b/lighthouse-core/config/default.js index c5221b8cfa2e..5a6e994d0334 100644 --- a/lighthouse-core/config/default.js +++ b/lighthouse-core/config/default.js @@ -222,7 +222,6 @@ module.exports = { }, 'performance': { name: 'Performance', - weight: 1, description: 'These encapsulate your app\'s current performance and opportunities to improve it.', audits: [ {id: 'first-meaningful-paint', weight: 5, group: 'perf-metric'}, @@ -248,7 +247,6 @@ module.exports = { }, 'accessibility': { name: 'Accessibility', - weight: 1, description: 'These checks highlight opportunities to [improve the accessibility of your app](https://developers.google.com/web/fundamentals/accessibility).', audits: [ {id: 'accesskeys', weight: 1, group: 'a11y-correct-attributes'}, @@ -290,7 +288,6 @@ module.exports = { }, 'best-practices': { name: 'Best Practices', - weight: 1, description: 'We\'ve compiled some recommendations for modernizing your web app and avoiding performance pitfalls.', audits: [ {id: 'appcache-manifest', weight: 1}, From a9561070b3c30ba7af05a6ce11fedc850f851a2e Mon Sep 17 00:00:00 2001 From: Steve Persch Date: Wed, 11 Oct 2017 17:07:06 -0500 Subject: [PATCH 3/3] Setting weight on performance category --- lighthouse-core/config/perf.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lighthouse-core/config/perf.json b/lighthouse-core/config/perf.json index 1de0ac72b31f..cb3e3b7dbc93 100644 --- a/lighthouse-core/config/perf.json +++ b/lighthouse-core/config/perf.json @@ -2,5 +2,10 @@ "extends": "lighthouse:default", "settings": { "onlyCategories": ["performance"] + }, + "categories": { + "performance": { + "weight": 1 + } } }