From 3217b31119eb42bc32b846e99b6ae6ef1d2f3788 Mon Sep 17 00:00:00 2001 From: Patrick Hulce Date: Wed, 13 Feb 2019 09:42:04 -0600 Subject: [PATCH 1/2] core(unused-css): change title Defer -> Remove --- lighthouse-core/audits/byte-efficiency/unused-css-rules.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lighthouse-core/audits/byte-efficiency/unused-css-rules.js b/lighthouse-core/audits/byte-efficiency/unused-css-rules.js index 475d8657a2aa..c917155b0f76 100644 --- a/lighthouse-core/audits/byte-efficiency/unused-css-rules.js +++ b/lighthouse-core/audits/byte-efficiency/unused-css-rules.js @@ -10,10 +10,10 @@ const i18n = require('../../lib/i18n/i18n.js'); const UIStrings = { /** Imperative title of a Lighthouse audit that tells the user to remove content from their CSS that isn’t needed immediately and instead load that content at a later time. This is displayed in a list of audit titles that Lighthouse generates. */ - title: 'Defer unused CSS', + title: 'Remove unused CSS', /** Description of a Lighthouse audit that tells the user *why* they should defer loading any content in CSS that isn’t needed at page load. This is displayed after a user expands the section to see more. No word length limits. 'Learn More' becomes link text to additional documentation. */ - description: 'Remove unused rules from stylesheets to reduce unnecessary ' + - 'bytes consumed by network activity. ' + + description: 'Remove dead rules from stylesheets and defer the loading of CSS not used for ' + + 'above-the-fold content to reduce unnecessary bytes consumed by network activity. ' + '[Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).', }; From ffd9dcbe305c9efed4c97592cc25481fe7dda2b0 Mon Sep 17 00:00:00 2001 From: Patrick Hulce Date: Wed, 13 Feb 2019 09:43:30 -0600 Subject: [PATCH 2/2] sample json --- lighthouse-core/lib/i18n/en-US.json | 4 ++-- lighthouse-core/test/results/sample_v2.json | 4 ++-- proto/sample_v2_round_trip.json | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lighthouse-core/lib/i18n/en-US.json b/lighthouse-core/lib/i18n/en-US.json index 2beef88eb553..850c3e3b0dc8 100644 --- a/lighthouse-core/lib/i18n/en-US.json +++ b/lighthouse-core/lib/i18n/en-US.json @@ -504,11 +504,11 @@ "description": "Imperative title of a Lighthouse audit that tells the user to minify the page’s JS code to reduce file size. This is displayed in a list of audit titles that Lighthouse generates." }, "lighthouse-core/audits/byte-efficiency/unused-css-rules.js | description": { - "message": "Remove unused rules from stylesheets to reduce unnecessary bytes consumed by network activity. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).", + "message": "Remove dead rules from stylesheets and defer the loading of CSS not used for above-the-fold content to reduce unnecessary bytes consumed by network activity. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).", "description": "Description of a Lighthouse audit that tells the user *why* they should defer loading any content in CSS that isn’t needed at page load. This is displayed after a user expands the section to see more. No word length limits. 'Learn More' becomes link text to additional documentation." }, "lighthouse-core/audits/byte-efficiency/unused-css-rules.js | title": { - "message": "Defer unused CSS", + "message": "Remove unused CSS", "description": "Imperative title of a Lighthouse audit that tells the user to remove content from their CSS that isn’t needed immediately and instead load that content at a later time. This is displayed in a list of audit titles that Lighthouse generates." }, "lighthouse-core/audits/byte-efficiency/unused-javascript.js | description": { diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json index 950cfedddf29..2c50f0518c32 100644 --- a/lighthouse-core/test/results/sample_v2.json +++ b/lighthouse-core/test/results/sample_v2.json @@ -2410,8 +2410,8 @@ }, "unused-css-rules": { "id": "unused-css-rules", - "title": "Defer unused CSS", - "description": "Remove unused rules from stylesheets to reduce unnecessary bytes consumed by network activity. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).", + "title": "Remove unused CSS", + "description": "Remove dead rules from stylesheets and defer the loading of CSS not used for above-the-fold content to reduce unnecessary bytes consumed by network activity. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).", "score": 1, "scoreDisplayMode": "numeric", "rawValue": 0, diff --git a/proto/sample_v2_round_trip.json b/proto/sample_v2_round_trip.json index f365ce24c794..9a97077187a3 100644 --- a/proto/sample_v2_round_trip.json +++ b/proto/sample_v2_round_trip.json @@ -2540,7 +2540,7 @@ "warnings": [] }, "unused-css-rules": { - "description": "Remove unused rules from stylesheets to reduce unnecessary bytes consumed by network activity. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).", + "description": "Remove dead rules from stylesheets and defer the loading of CSS not used for above-the-fold content to reduce unnecessary bytes consumed by network activity. [Learn more](https://developers.google.com/web/tools/lighthouse/audits/unused-css).", "details": { "headings": [], "items": [], @@ -2551,7 +2551,7 @@ "id": "unused-css-rules", "score": 1.0, "scoreDisplayMode": "numeric", - "title": "Defer unused CSS" + "title": "Remove unused CSS" }, "use-landmarks": { "description": "Landmark elements (
,